feat: add configurable DML row counts and skip disabled test_get_objects_ instead of strict xfails - #271
Open
Mandukhai-Alimaa wants to merge 2 commits into
Conversation
…ead of strict xfails
lidavidm
approved these changes
Jul 27, 2026
| statement_prepare: bool = Field(default=False) | ||
| statement_rows_affected: bool = Field(default=False) | ||
| # Some backends report zero for every ordinary DML statement (ex: Databend) | ||
| statement_rows_affected_dml_returns_zero: bool = Field(default=False) |
Contributor
There was a problem hiding this comment.
nit, but maybe this could be a 'quirk' (see below)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some backends, such as Databend, report 0 rows affected for DML statements. Add a driver feature flag so the validation suite can expect this behavior.
Skipped
test_get_objects_instead of marking strict xfail when disabled. In the MySQL driver, unfiltered GetObjects uses a plain query and may succeed on Databend, while filtered GetObjects uses bound parameters and falls back to prepared statements, which Databend does not support. With strict xfail, unfiltered cases can pass and turn into misleading XPASS failures even though get_objects is disabled for that backend. Skipping is clearer.