ci(.github): adopt engine #88 — sub-dir .bot/prompts + ENGINE_REF 5fbcee18#560
Merged
Merged
Conversation
eric-wang-1990
requested review from
gopalldb,
lidavidm,
msrathore-db and
vikrantpuppala
as code owners
June 29, 2026 23:36
eric-wang-1990
changed the title
eric-wang-1990
changed the title
eric-wang-1990
added
review-bot
…xt-repos) Picks up engine #84: the follow-up flow now wires the .bot/context-repos.yaml allowlist into its agent (parity with the author phase), so a review-comment reply can fetch/read reference repos (e.g. databricks-jdbc) to VERIFY a cross-driver parity claim instead of answering from memory (the gap behind the #544 JDBC answer). All four workflows bumped in lockstep. Co-authored-by: Isaac
…ollowup config Re-targets the ENGINE_REF bump from 11f9bc8 (#84) to the current engine main HEAD 45fd59f, adopting #85 (unified-config groundwork; env-only reviewer rules/skills; config-only identity) and #87 (reviewer stays zero-config). All four workflow pins updated in sync. Also aligns .bot/config.yaml with what the engine actually consumes: removes the `followup:` block. The engine reads NO followup block (bot_config.py parses only `author:` + shared keys, verified at 45fd59f) — the follow-up phase uses .bot/prompts/followup_system.md + the PR thread + author.knowledge_log. The block (and its unresolved `# VERIFY` comment) was dead config; replaced with a note. Co-authored-by: Isaac
Templatize .bot/config.yaml so it maps the whole bot setup. Adds a commented "Reviewer bots" section explaining the reviewer reads NOTHING from this file (engine-owned prompts; customized via .bot/prompts/review*_system.md files + REPO_RULES_FILES / REPO_SKILLS workflow env), with an explicit "do NOT add a review: block — it's dead config" warning. Comments only, never real keys, so we don't reintroduce the dead-config trap we just removed for `followup:`. Co-authored-by: Isaac
… ENGINE_REF 5fbcee18 Engine #88 moved prompts to the convention layout .bot/prompts/<phase>/<role>.md and dropped author.user_prompt_template. Migrate this consumer in lockstep with the ENGINE_REF bump (45fd59f -> 5fbcee18, the #88 merge) so the engine finds its prompts: - git mv author_system.md -> engineer/system.md - git mv author_user.md -> engineer/user.md - git mv followup_system.md -> engineer-followup/system.md - git rm followup_user.md (dead — engine never rendered it; followup builds its user prompt from the PR thread) - .bot/config.yaml: drop author.user_prompt_template (the author user prompt is now the convention file engineer/user.md); comment paths updated. - .rat-excludes: .bot/prompts/*.md -> .bot/prompts/** so the sub-dir prompt files stay license-header-excluded (flat glob no longer matches the subdirs). No reviewer overrides here (review/ + review-followup/ omitted → engine defaults). Co-authored-by: Isaac
eric-wang-1990
force-pushed
the
ci/bump-engine-ref-followup-context-repos
branch
from
July 1, 2026 23:04
cd97bd0 to
aff1fe0
Compare
eric-wang-1990
changed the title
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the latest engine (
5fbcee18, #88 merge) and migrates this consumer's.bot/to match — the two are coupled (engine #88 is a breaking prompt-layout change).Prompt layout → sub-dir convention (
.bot/prompts/<phase>/<role>.md):author_system.md→engineer/system.mdauthor_user.md→engineer/user.mdfollowup_system.md→engineer-followup/system.mdfollowup_user.md→ deleted (dead — the engine never rendered it; the follow-up builds its user prompt from the PR thread)Config: dropped
author.user_prompt_template(the author user prompt is now the convention fileengineer/user.md— no config path). Also (earlier in this PR) removed the deadfollowup:block and documented the reviewer's no-config surface as comments..rat-excludes:.bot/prompts/*.md→.bot/prompts/**so the sub-dir prompt files stay license-header-excluded (the flat glob no longer matches the subdirs).ENGINE_REF:45fd59f→5fbcee18across all four bot workflows — picks up #85 (env-only reviewer rules/skills; config-only identity), #87 (reviewer zero-config), and #88 (prompt sub-dir layout).No reviewer overrides in this repo, so
review/+review-followup/are omitted (engine defaults apply).