Skip to content

Fix for date unnamed module - #447

Open
saurav-mukherjee-telus wants to merge 1 commit into
developfrom
feature/INTERLOK-4723-fix-date-module-not-named
Open

Fix for date unnamed module#447
saurav-mukherjee-telus wants to merge 1 commit into
developfrom
feature/INTERLOK-4723-fix-date-module-not-named

Conversation

@saurav-mukherjee-telus

Copy link
Copy Markdown
Contributor

Motivation

https://telusagriculture.atlassian.net/browse/INTERLOK-4723

Modification

When building PG Network projects ,exception -
Failed with exceptions:
Unable to make field private final long java.time.Duration.seconds accessible: module java.base does not "opens java.time" to unnamed module @72a7c7e0

PR Checklist

  • been self-reviewed.
  • Added javadocs for most classes and all non-trivial methods
  • Added supporting annotations (like @XStreamAlias / @ComponentProfile)
  • Added DefaultValue annotation when there is a default value (e.g. @DefaultValue('true'))
  • Added validation annotation (@NotNull...) when required and add @Valid when nested class has some validation
  • Checked that @NotNull and @notblank annotations have a meaningful message when appropriate.
  • Checked that new 3rd party dependencies are appropriately licensed
  • Added comments explaining the "why" and the intent of the code wherever it would not be obvious for an unfamiliar reader
  • Added unit tests or modified existing tests to cover new code paths
  • Tested new/updated components in the UI and at runtime in an Interlok instance
  • Reviewed java class members so that missing annotations are added (InputFieldDefault/ComponentProfile etc)
  • Checked that javadoc generation doesn't report errors
  • Checked the display of the component in the UI
  • Remove any config/license annotations
  • Check the gradle build file to make sure the dependencies section is more explicit "implementation/api".

Result

PG Network build and interlokConfigVerifyCheck Tasks run successfully on all machines.

Testing

Run build task on the project which should succeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants