Support custom logout actions - #72
Open
hmpf wants to merge 1 commit into
Open
Conversation
hmpf
force-pushed
the
custom-logout-action
branch
from
October 8, 2020 12:39
c983b85 to
e1d3417
Compare
hmpf
force-pushed
the
custom-logout-action
branch
from
October 9, 2020 11:20
e1d3417 to
c828e3c
Compare
Collaborator
|
@hmpf Could you please rebase this PR to the current develop in order to run the tests here in GitHub Actions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I've finally gotten around to setting things up!
Problem: this needs to be logged to the audit log, and the log for starting to impersonate (on
login_as_user) needs to be different from the log for stopping to impersonate (onsu_logout). This could also be solved bylogin_as_usersending asu-signal andsu_logoutsending anunsu-signal.Also, #70 might be solved by adding a check that the user you su to is not a superuser in the custom login action, and not doing so in the custom logout action, which is also a problem I have: I don't want superusers to impersonate superusers. This should also fix my third problem: recursive su.
Might help in closing #70.