Avoid C414 for stable multi-key sorted calls - #662
Open
onuracar-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #661.
Summary
sorted(sorted(...), key=<non-None>): Python's stable sort allows the inner sort to establish a secondary ordering.**expansion may provide the key.key=Noneand the existing genuinely redundant cases.Validation
**kwargsand literal**{"key": len}cases also failed before their guard was added.pre-commit run --all-files: all hooks passed, including RST checks, Ruff, formatting, and MyPy.uv build: wheel and sdist built successfully.git diff --checkand staged secret scan: passed.AI disclosure: OpenAI Codex (GPT-5) analyzed the issue and generated/revised the implementation, tests, documentation, changelog text, commit message, and this pull-request description. Independent Codex review passes found and corrected a remaining
**kwargsfalse positive before publication, then re-reviewed the final commit and validation results. No separate human review is being represented here.