Skip to content

Add version checking fix, tweak lists - #357

Draft
tyeth wants to merge 1 commit into
adafruit:mainfrom
tyeth:arduino-semver-check-and-tweak-lists
Draft

Add version checking fix, tweak lists#357
tyeth wants to merge 1 commit into
adafruit:mainfrom
tyeth:arduino-semver-check-and-tweak-lists

Conversation

@tyeth

@tyeth tyeth commented Sep 26, 2023

Copy link
Copy Markdown
Member
  • Adds check for semver latest using arduino library registry
  • Strip version number for FONA repo (\r)
  • List unreleased libraries as needing release
  • Adds comparison link for live repos with changes
  • Adds timestamp to bad lists to help identify relevence
  • Add list of No-Examples libraries (was silent ignore)

@tyeth
tyeth force-pushed the arduino-semver-check-and-tweak-lists branch from 7d34779 to 7a76613 Compare September 26, 2023 16:45
@tyeth
tyeth force-pushed the arduino-semver-check-and-tweak-lists branch from a869f39 to 82e448c Compare September 26, 2023 17:05
@tyeth

tyeth commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

@ladyada there were a few more issues in the script than I initially thought. This addresses the missing functionality around version numbers, and output list fixes.

@tyeth
tyeth requested a review from ladyada September 26, 2023 17:16
@jepler

jepler commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

@tyeth assuming you have merge permissions, it's fine for you to merge your own PR after it's been approved. If you don't have permissions, I can do it and you can raise the issue of getting merge access at your convenience.

@tyeth

tyeth commented Nov 27, 2023

Copy link
Copy Markdown
Member Author

Thanks @jepler! I've kind of let this one sit while I use it for a while (few more improvements on https://github.com/tyeth/adabot/tree/arduino-ci-ver-bump), although I also thought I did have merge powers, but alas I do not! Don't worry about merging for now, and I'll sort my access this week.

@dhalbert
dhalbert marked this pull request as draft November 28, 2023 14:20
@dhalbert

Copy link
Copy Markdown
Contributor

I flipped this to draft so it won't get merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants