Sync url and urlpattern test data from web-platform-tests. - #1158
Merged
Conversation
watilde
force-pushed
the
test/update-wpt
branch
7 times, most recently
from
June 28, 2026 07:51
9a58e0e to
d44533a
Compare
Known IDNA conformance gaps surfaced by the new data (tracked upstream in ada-url/idna, src/ada_idna.cpp is auto-generated): - ContextJ C1 (ZWNJ): xn--ab-j1t - empty punycode label: xn-- - TR46 validity for enclosed alphanumerics: xn--pokxncvks Also reformat src/url_pattern_helpers.cpp for clang-format 22 (the lint CI was bumped from v17 to v22 in ada-url#1106); the existing line wrapping no longer conforms. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
anonrig
approved these changes
Jun 30, 2026
Member
|
this pr broke the CI for windows |
Contributor
Author
|
Oh sorry.. Let me make revert PR to fix that. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known IDNA conformance gaps surfaced by the new data (tracked upstream in ada-url/idna, src/ada_idna.cpp is auto-generated):
refs: nodejs/node#64177