Fix duplicate and contradictory DE-9IM results for byte-identical geometries - #24
Merged
Conversation
…or equivalent linestrings, fix a rare issue in which references were not found, add a few regression tests, update util
Escape the decimal dot in the six new test patterns and write both tab separators as `\\t`. Use standard WKT for the linestrings `lsa` and `lsb` in the `issue-23` dataset, which had doubled parentheses. Also remove a stray semicolon next to a line already touched on this branch.
hannahbast
changed the title
hannahbast
changed the title
DE-9IM results for byte-identical geometries
Member
Author
Work on this will continue in #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byte-identical geometries with at least 500 points were reported twice under
--de9im. For linestrings the two reports could even contradict each other, because the hardcoded matrix for equivalent linestrings was wrong (it is now1FFF0FFF2). Also fix a rare issue in the duplicate removal, where line and polygon ids from independent counters shared one bookkeeping set. Fixes #23.On the side, update
utilto include the fixes for ad-freiburg/util#12 and ad-freiburg/util#13, and add regression tests for those as well.NOTE: With three or more byte-identical copies of the same geometry, the pairs between the copies are still reported twice. This also affects the classic relations and predates this change.