fix(nvidia): remover stream_options do NIM - #195
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR ajusta o provider NVIDIA NIM para não enviar stream_options nas requisições OpenAI-compatible, evitando incompatibilidade com o endpoint da NVIDIA, e adiciona um teste unitário garantindo esse comportamento.
Changes:
- Introduz
buildNvidiaNimBody()para montar o body OpenAI-compatible e removerstream_optionsantes do envio ao NIM. - Conecta o novo
bodyTransformao providernvidianim. - Adiciona teste cobrindo que
stream_optionsnão é enviado para chat via NVIDIA NIM.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/providers/nvidianim.ts | Adiciona bodyTransform específico para NVIDIA NIM removendo stream_options do body gerado. |
| server/tests/openai-compatible.test.ts | Inclui teste para garantir que o body transform do NVIDIA NIM não contém stream_options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Verificação