AK-508: ignore coding-agent review-findings dirs (.architect/, .reviewer/) - #2
Draft
benw5483 wants to merge 1 commit into
Draft
AK-508: ignore coding-agent review-findings dirs (.architect/, .reviewer/)#2benw5483 wants to merge 1 commit into
benw5483 wants to merge 1 commit into
Conversation
This repository had no .gitignore at all. Automated review tooling writes .architect/ and .reviewer/ directories at the root of a working tree. They hold internal run identifiers and raw review commentary, so a broad `git add -A` recovery could sweep them into a pull request. Nothing matching the new patterns is tracked today. `git ls-files | grep -E '^\.(architect|reviewer)/'` returns empty, so this is a purely additive change that untracks nothing and removes no existing entry. Also adds a .DS_Store baseline. No node_modules/ or __pycache__ entries, since this repository carries only Markdown, a LICENSE, and one shell script. Generated by the operator's software factory. City: factory-main · Agent: local-core.builder-2 On behalf of: @benw5483 Co-Authored-By: <operator-factory-bot> <factory-bot@actual.ai.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore. This adds one..architect/and.reviewer/directories that automated review tooling writes at the root of a working tree. They hold internal run identifiers and raw review commentary, so a broadgit add -Arecovery could otherwise sweep them into a pull request..DS_Storebaseline. Nonode_modules/or__pycache__entries, because this repository carries only Markdown, a LICENSE, and one shell script.The explanatory comment above the two entries is deliberate. It tells the next reader why the entries exist, so they are not deleted later as noise.
Verification
Nothing matching the new patterns was already tracked.
git ls-files | grep -E '^\.(architect|reviewer)/'returns empty on this branch, so no committed file becomes untracked and nothing needs removing. This is the check that mattered most here: had it come back non-empty, findings would already be in the history and cleaning them out would be a separate and more careful job than adding an ignore rule.The change is additive only. It creates one new file, removes no existing ignore entry, reorders nothing, and touches no other file in the repository.
The rules were exercised rather than assumed. With
.architect/round-1.findings.jsonand.reviewer/round-1.findings.jsonpresent on disk:git status --porcelain?? .gitignore, the findings files are invisiblegit check-ignore -v.gitignore:7:.architect/and.gitignore:8:.reviewer/git add -A --dry-run.gitignorealone, so the sweep this guards against no longer picks them upBoth scratch directories were removed afterward; the working tree is clean.
Test plan
git ls-files | grep -E '^\.(architect|reviewer)/'is empty onmain..architect/x.jsonand.reviewer/x.jsonlocally, then confirmgit statusstays clean andgit add -A --dry-rundoes not stage them..gitignoreonly.