Skip to content

AK-508: ignore coding-agent review-findings dirs (.architect/, .reviewer/) - #2

Draft
benw5483 wants to merge 1 commit into
mainfrom
ak-508-ignore-agent-findings-dirs
Draft

AK-508: ignore coding-agent review-findings dirs (.architect/, .reviewer/)#2
benw5483 wants to merge 1 commit into
mainfrom
ak-508-ignore-agent-findings-dirs

Conversation

@benw5483

Copy link
Copy Markdown

Summary

  • This repository had no .gitignore. This adds one.
  • Ignores the .architect/ and .reviewer/ directories that automated review tooling writes at the root of a working tree. They hold internal run identifiers and raw review commentary, so a broad git add -A recovery could otherwise sweep them into a pull request.
  • Adds a .DS_Store baseline. No node_modules/ or __pycache__ entries, because this repository carries only Markdown, a LICENSE, and one shell script.

The explanatory comment above the two entries is deliberate. It tells the next reader why the entries exist, so they are not deleted later as noise.

Verification

Nothing matching the new patterns was already tracked. git ls-files | grep -E '^\.(architect|reviewer)/' returns empty on this branch, so no committed file becomes untracked and nothing needs removing. This is the check that mattered most here: had it come back non-empty, findings would already be in the history and cleaning them out would be a separate and more careful job than adding an ignore rule.

The change is additive only. It creates one new file, removes no existing ignore entry, reorders nothing, and touches no other file in the repository.

The rules were exercised rather than assumed. With .architect/round-1.findings.json and .reviewer/round-1.findings.json present on disk:

Check Result
git status --porcelain shows only ?? .gitignore, the findings files are invisible
git check-ignore -v attributes them to .gitignore:7:.architect/ and .gitignore:8:.reviewer/
git add -A --dry-run stages .gitignore alone, so the sweep this guards against no longer picks them up

Both scratch directories were removed afterward; the working tree is clean.

Test plan

  • Confirm git ls-files | grep -E '^\.(architect|reviewer)/' is empty on main.
  • Create .architect/x.json and .reviewer/x.json locally, then confirm git status stays clean and git add -A --dry-run does not stage them.
  • Confirm the diff adds .gitignore only.

Generated by the operator's software factory.
• City: factory-main · Agent: local-core.builder-2
• On behalf of: @benw5483

This repository had no .gitignore at all. Automated review tooling writes
.architect/ and .reviewer/ directories at the root of a working tree. They
hold internal run identifiers and raw review commentary, so a broad
`git add -A` recovery could sweep them into a pull request.

Nothing matching the new patterns is tracked today. `git ls-files |
grep -E '^\.(architect|reviewer)/'` returns empty, so this is a purely
additive change that untracks nothing and removes no existing entry.

Also adds a .DS_Store baseline. No node_modules/ or __pycache__ entries,
since this repository carries only Markdown, a LICENSE, and one shell script.

Generated by the operator's software factory.
City: factory-main · Agent: local-core.builder-2
On behalf of: @benw5483
Co-Authored-By: <operator-factory-bot> <factory-bot@actual.ai.invalid>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant