AK-508: add root .gitignore for agent gate-findings dirs - #2
Draft
benw5483 wants to merge 2 commits into
Draft
Conversation
Factory agents write .architect/ and .reviewer/ gate-findings directories at the repo root of every worktree. They carry internal identifiers and raw review commentary. This repo had no root .gitignore, so a broad `git add -A` recovery could sweep them into a PR. Adds a root .gitignore with those two entries, plus the baseline appropriate to this repo's languages: .DS_Store, and node_modules/ because the repo ships five npm package manifests. No Python, Go, or Rust sources are present here, so ignores for those were deliberately left out. Verified before committing that no tracked file already matched the new patterns, and confirmed by probe that a broad `git add -A` with findings dirs present stages nothing but this file. The existing npm/.gitignore, which covers CI binary payloads, is untouched. Generated by the operator's software factory. City: factory-main · Agent: local-core.builder-5 On behalf of: @benw5483 Co-Authored-By: <operator-factory-bot> <factory-bot@actual.invalid>
The three sibling repos in this sweep all carry a de-jargoned version of this comment: "Coding-agent review-findings dirs" rather than "Agent gate findings dirs (architect/reviewer rounds)", and "internal run identifiers" rather than the internal task-tracker vocabulary. This repo is public and had been left on the older wording. The revision exists precisely so that internal vocabulary does not ship into a public repo, so this brings the file in line with the other three byte for byte. Comment text only. The ignored paths, the baseline entries, and every other file are unchanged, and the probe check still shows a broad `git add -A` staging this file and nothing else. Generated by the operator's software factory. City: factory-main · Agent: local-core.builder-5 On behalf of: @benw5483 Co-Authored-By: <operator-factory-bot> <factory-bot@actual.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore. This repo had none. A subtree-scopednpm/.gitignorecovering CI binary payloads already exists, and this change leaves it alone..architect/and.reviewer/, the review-findings directories that automated coding-agent tooling writes at the repo root of a working tree. They hold internal run identifiers and raw review commentary, so a broadgit add -Arecovery could otherwise sweep them into a PR..DS_Store, plusnode_modules/because the repo ships five npm package manifests. There are no Python, Go, or Rust sources here, so ignores for those were deliberately left out.Nothing matching was already tracked
git ls-files | grep -E '^\.(architect|reviewer)/'returns empty, so no findings were ever committed here and nothing needs untracking. This change is purely a forward-looking guard.The diff is additive: one new file, 11 insertions, no deletions. No existing ignore entry was removed or reordered, and no other file in the repo was touched.
Test plan
git ls-files | grep -E '^\.(architect|reviewer)/'is emptygit check-ignore -vresolves each pattern against a probe file:.architect/round-1.findings.json,.reviewer/round-1.findings.json,node_modules/probe/index.js,.DS_Storegit add -Astages.gitignoreand nothing else. That is the recovery move this change exists to make safe.git status --porcelainis clean once the probes are removed, andnpm/.gitignoreis unmodified