refactor(detray): Split MBF parameter updater into new class

[stephenswat]

This commit splits the parameter updater type in two, preserving a non-MBF-enabled version and a new type which supports Jacobian propagation for MBF workflows.

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --conditions-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298341 to 298342 (+0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50212 to 50212 (+0.0%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	8474feb	cdc392e	Delta	8474feb	cdc392e
propagate_to_next_surface	4.20 ms	4.20 ms	0.0%	4.88	4.88
find_tracks	1.19 ms	1.19 ms	0.6%	1.84	1.83
count_doublets	792.57 μs	789.21 μs	-0.4%	1.61	1.61
count_triplets	557.73 μs	557.16 μs	-0.1%	1.02	1.02
find_doublets	514.00 μs	513.16 μs	-0.2%	3.08	3.08
ccl_kernel	434.11 μs	434.77 μs	0.2%	1.71	1.71
Thrust::sort	384.57 μs	384.32 μs	-0.1%	7.27	7.27
condense_tracks	250.69 μs	250.78 μs	0.0%	5.76	5.76
find_triplets	161.22 μs	160.19 μs	-0.6%	1.31	1.31
build_tracks	125.53 μs	125.37 μs	-0.1%	3.72	3.71
select_seeds	58.65 μs	58.55 μs	-0.2%	1.34	1.34
estimate_track_params	26.43 μs	26.35 μs	-0.3%	2.68	2.69
populate_grid	23.59 μs	23.56 μs	-0.1%	1.22	1.22
count_grid_capacities	21.91 μs	21.95 μs	0.2%	1.22	1.22
remove_duplicates	20.00 μs	19.84 μs	-0.8%	25.63	25.77
fill_sorted_measurements	16.18 μs	16.08 μs	-0.6%	1.13	1.13
update_triplet_weights	14.74 μs	14.64 μs	-0.7%	1.27	1.27
fill_finding_propagation_sort_keys	9.85 μs	9.84 μs	-0.1%	7.22	7.23
form_spacepoints	7.44 μs	7.43 μs	-0.1%	1.47	1.48
reduce_triplet_counts	5.50 μs	5.50 μs	-0.1%	3.08	3.08
unknown	5.05 μs	5.04 μs	-0.2%	4.27	4.27
count_spacepoints	2.99 μs	2.99 μs	-0.1%	1.47	1.47
Thrust::scan	1.79 μs	1.78 μs	-0.4%	92.69	92.82
fill_finding_duplicate_removal_sort_keys	1.55 μs	1.55 μs	-0.1%	38.13	38.14
create_device_detector	None	None	0.1%	32764.72	32764.72
Total	8.82 ms	8.82 ms	0.0%	3.73	3.73

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Public API surface diff

No change to the public API surface. ✅

[github-actions]

📊: Physics performance monitoring for cdc392e

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding
• 🔵️ Comparison - Truth tracking (GX2F vs KF)