Skip to content

feat: Sensor-local PODIO measurement type - #4123

Merged
kodiakhq[bot] merged 19 commits into
acts-project:mainfrom
paulgessinger:feat/edm4hep-tracker-local
Feb 27, 2026
Merged

feat: Sensor-local PODIO measurement type#4123
kodiakhq[bot] merged 19 commits into
acts-project:mainfrom
paulgessinger:feat/edm4hep-tracker-local

Conversation

@paulgessinger

@paulgessinger paulgessinger commented Mar 5, 2025

Copy link
Copy Markdown
Member

@paulgessinger paulgessinger added this to the next milestone Mar 5, 2025
@coderabbitai

coderabbitai Bot commented Mar 5, 2025

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Mar 5, 2025
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from e90a19b to 2ff7a59 Compare March 21, 2025 10:43
@github-actions github-actions Bot added the Component - Documentation Affects the documentation label Mar 21, 2025
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from 2ff7a59 to f491b62 Compare March 25, 2025 15:23
@github-actions github-actions Bot added the Stale label Apr 24, 2025
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from f491b62 to 5240d46 Compare February 19, 2026 13:26
@github-actions github-actions Bot added Component - Core Affects the Core module Event Data Model and removed Component - Documentation Affects the documentation labels Feb 19, 2026
@paulgessinger paulgessinger changed the title feat: Write measurement to sensor-local tracker hit in EDM4hep feat: Sensor-local PODIO type Feb 19, 2026
@paulgessinger paulgessinger changed the title feat: Sensor-local PODIO type feat: Sensor-local PODIO measurement type Feb 19, 2026
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from 5240d46 to fcef3f1 Compare February 19, 2026 14:30
@paulgessinger
paulgessinger marked this pull request as ready for review February 19, 2026 17:33
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Feb 19, 2026
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from 5d60881 to 5a1072c Compare February 19, 2026 17:49
@github-actions github-actions Bot removed the Stale label Feb 19, 2026
@github-actions

github-actions Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 5cb0727

Full contents

physmon summary

❗️: Downstream build failure

  • eic-shell (cc @acts-project/epic-contacts)

kodiakhq Bot pushed a commit that referenced this pull request Feb 20, 2026
This PR allows querying both `Acts::Any` as well as `Acts::SourceLink` for their contained type. I'm using this in #4123 to support different source link setting modes.
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 20, 2026
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from ab840cd to 7c45115 Compare February 20, 2026 16:27
@github-actions github-actions Bot removed Component - Core Affects the Core module Event Data Model labels Feb 20, 2026
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch 2 times, most recently from 9f73f49 to 8031d51 Compare February 26, 2026 13:16
@paulgessinger
paulgessinger force-pushed the feat/edm4hep-tracker-local branch from 8031d51 to c1649d4 Compare February 27, 2026 07:16
Comment thread Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepUtil.hpp
Comment thread Plugins/EDM4hep/include/ActsPlugins/EDM4hep/EDM4hepUtil.hpp Outdated
Comment thread Plugins/EDM4hep/src/EDM4hepUtil.cpp
andiwand
andiwand previously approved these changes Feb 27, 2026
@paulgessinger

Copy link
Copy Markdown
Member Author

@andiwand feedback is in. I'll follow this up with

  • a rework of where the encoding/decoding logic lives to enable upstreaming hopefully
  • unify with the more generic PODIO measurement code (I'll remove that in favor of this)
  • integration with a new track edm reader / writer combo

@sonarqubecloud

Copy link
Copy Markdown

@kodiakhq
kodiakhq Bot merged commit dcf5069 into acts-project:main Feb 27, 2026
52 of 53 checks passed
@andiwand andiwand modified the milestones: next, v45.3.0 Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants