Skip to content

fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: e2e_tests check don't work on a PR from a fork due to AWS' configure-aws-credentials bug #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ jobs:
"$GITHUB_WORKSPACE/test-files/scripts/test-local-e2e.sh"

- name: configure aws credentials
if: ${{ github.event.pull_request.head.repo.fork == false }}
# Configures AWS credential and region environment variables for use in other GitHub Actions.
Comment on lines 108 to 110
# The environment variables will be detected by both the AWS SDKs and the AWS CLI to determine the credentials and region to use for AWS API calls.
# More on this action at https://github.com/aws-actions/configure-aws-credentials
Expand All @@ -115,13 +116,15 @@ jobs:
aws-region: us-west-2

- name: prepare to run remote end-to-end test
if: ${{ github.event.pull_request.head.repo.fork == false }}
run: |
cd "$GITHUB_WORKSPACE/examples/basic"
npm i
# update to use the local plugin built above
npm install --save file://../../serverless-aws-static-file-handler-0.0.0.tgz

- name: run remote end-to-end test
if: ${{ github.event.pull_request.head.repo.fork == false }}
run: |
cd "$GITHUB_WORKSPACE/examples/basic"
echo "Deploying serverless stage $SERVERLESS_STAGE"
Expand Down Expand Up @@ -153,7 +156,7 @@ jobs:

- name: cleanup remote end-to-end test (destroy serverless stack)
# Run this step even if the prior one failed (to clean up)
if: ${{ always() }}
if: ${{ always() && github.event.pull_request.head.repo.fork == false }}
run: |
cd "$GITHUB_WORKSPACE/examples/basic"
echo "Destroying serverless stage $SERVERLESS_STAGE"
Expand Down