Fixed SUVM allocation for the Anjuna build case - #5
Open
yanjuna wants to merge 7 commits into
Open
Conversation
shmeni
reviewed
Apr 19, 2020
| make -C ../../../mstores -f Makefile SDK_BUILD="-DGRAPHENE_BUILD" NO_COUNTERS="-DNO_COUNTERS" SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20"; | ||
| make -C ../../../pass -f Makefile SDK_BUILD="-DANJUNA_BUILD" NO_COUNTERS="-DNO_COUNTERS" SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20"; | ||
| make -C ../../../runtime -f Makefile SDK_BUILD="-DANJUNA_BUILD" NO_COUNTERS="-DNO_COUNTERS" SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20"; | ||
| make -C ../../../mstores -f Makefile SDK_BUILD="-DANJUNA_BUILD" NO_COUNTERS="-DNO_COUNTERS" SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20"; |
Collaborator
There was a problem hiding this comment.
Can we keep the Graphene example as well? e.g., making cosmix_graphene,redis-server_suvm_graphene and cosmix_anjuna,redis-server_suvm_anjuna rules with the appropriate libOS flags?
Contributor
Author
|
Sure, yeah we should. I was just committing my local changes and I guess I didn't pay attention to omitting Graphene.
…On Sun, Apr 19, 2020 at 7:46 AM, Meni < ***@***.*** > wrote:
***@***.**** commented on this pull request.
In samples/ redis-5. 0. 7/ src/ Cosmix. mk (
#5 (comment) ) :
> @@ -10,9 +10,9 @@ all: redis-server_native redis-server_scone
redis-server_suvm
SCONE_CXX=docker run --rm --device=/dev/isgx -v
"$(current_dir)"/../../..:/usr/src/myapp -w
/usr/src/myapp/samples/redis/src sconecuratedimages/crosscompilers:alpine
scone-g++
cosmix:
- make -C ../../../pass -f Makefile
SDK_BUILD="-DGRAPHENE_BUILD" NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
- make -C
../../../runtime -f Makefile SDK_BUILD="-DGRAPHENE_BUILD"
NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
- make -C
../../../mstores -f Makefile SDK_BUILD="-DGRAPHENE_BUILD"
NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
+ make -C ../../../pass
-f Makefile SDK_BUILD="-DANJUNA_BUILD" NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
+ make -C
../../../runtime -f Makefile SDK_BUILD="-DANJUNA_BUILD"
NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
+ make -C
../../../mstores -f Makefile SDK_BUILD="-DANJUNA_BUILD"
NO_COUNTERS="-DNO_COUNTERS"
SUVM_PAGE_CACHE_BITS="-DSUVM_PAGE_CACHE_BITS=20";
Can we keep the Graphene example as well? e.g., making
cosmix_graphene,redis-server_suvm_graphene and
cosmix_anjuna,redis-server_suvm_anjuna rules with the appropriate libOS
flags?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
#5 (review)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AISO376KGR4WHP6ODYX7EA3RNMFDHANCNFSM4MLFALEA
).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned pointer wasn't checked for being NULL, and the treatment of it was returning NULL vs. exit(-1) as for the GRAPHENE case.