dataworker: compact tabular Slack summary for root bundle proposals#3414
Open
droplet-rl wants to merge 1 commit into
Open
dataworker: compact tabular Slack summary for root bundle proposals#3414droplet-rl wants to merge 1 commit into
droplet-rl wants to merge 1 commit into
Conversation
…oposals The proposer mrkdwn body now renders two aligned tables (bundle blocks, pool rebalance) instead of per-leaf JSON dumps. Paused chains (start == end) collapse onto one line with their paused block; pool-rebalance leaves whose every token is zero across netSendAmounts, runningBalances, and bundleLpFees collapse onto a "quiet leaves" line. The decimal-point alignment plus a per-amount formatter (2 decimals for |x|>=1 with thousands separators, 4 sig figs in fixed-point for sub-unit values) keeps small LP fees readable without resorting to scientific notation. Full leaf JSON is still emitted as part of the existing "Enqueuing new root bundle proposal txn" debug log, so the structured data remains available for forensics; only the Slack notification body changed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
droplet-rl
requested review from
bmzig,
dijanin-brat,
mrice32,
nicholaspai and
pxrl
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startBlock === endBlock) collapse onto a single🥶 paused: …line carrying the paused block number.netSendAmounts,runningBalances, andbundleLpFeescollapse onto aquiet leaves (all zero): …line; field names are preserved verbatim as column headers.|x| >= 1→ 2 decimals with thousand separators;0 < |x| < 1→ 4 significant figures in fixed-point notation (no scientific). Zero cells suppress to blank so non-zero values pop out.Dataworker#propose"Enqueuing new root bundle proposal txn"debug log under newpoolRebalanceLeaves/relayerRefundLeaves/slowRelayLeavesfields, so the structured data is still available for forensics.generateMarkdownForRootBundleis unchanged; it remains in use by the dispute path.Example rendered output against a recent proposal lives in the originating Slack thread.
Test plan
yarn tsc --noEmityarn lintyarn test test/Dataworker.proposeRootBundle.tsyarn test test/Dataworker.validateRootBundle.ts🤖 Generated with Claude Code