RSpec 3 compatibility#25
Open
sgerrand wants to merge 3 commits into
Open
Conversation
Updated the existing RSpec tests to run under RSpec 3. Changed use of `mock` and `stub` to use `double` and `allow` methods from rspec-mocks and rspec-expectations, respectively. Updated the deprecated 's' format shorthand for documentation output. Move specs to match class hierarchy and removed `include Kafka` to enforce test isolation.
Author
|
👋 @acrosa: Would you please review these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💁 These changes are designed to update the test suite to be compatible with RSpec v3.
mocktodouble(rspec-mocks compatibility)stubtoallow(rspec-expectations compatibility)include Kafkafromspec/spec_helper.rbI've also added a Travis CI configuration file to enable testing the library across a matrix of MRI Ruby versions.