Skip to content

Feature/show columns#195

Open
gro1m wants to merge 2 commits into
aconrad:masterfrom
gro1m:feature/show-columns
Open

Feature/show columns#195
gro1m wants to merge 2 commits into
aconrad:masterfrom
gro1m:feature/show-columns

Conversation

@gro1m

@gro1m gro1m commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

Another attempt of implementing show columns based on #160.

Related issue:

@gro1m

gro1m commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

@aconrad Is there still interest in this feature? Because the rebuild that it needs first affects all future development and involves a lot of chore work. Some changes in the meantime that the other request was open necessitated some rework. And I appreciate the time it takes to review these things, but I would also like that this feature is implemented in a somewhat timely manner.

@gro1m

gro1m commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

This is why I only did for the show and not for the diff command yet and also no tests for the moment in order to get your feedback on priority.

@aconrad

aconrad commented Jun 26, 2025

Copy link
Copy Markdown
Owner

@gro1m thanks so much for looking into this, I really appreciate it. I think it could be useful to have this feature since it was requested. Although honestly I don't know how common it is of a request. There aren't many columns to begin with.

But if we were to implement this in the least intrusive way, could we just pass the list of columns to render to the template? I understand it would be a waste of computation because we'd be gathering data for all columns and only rendering the ones we care at the end. But I feel it would be an easier implementation to begin with. What do you think?

@gro1m gro1m force-pushed the feature/show-columns branch from 57dc3d0 to 44c9229 Compare June 29, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants