Skip to content

refactor about page and team page #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarush-narang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor about page and team page #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .husky/_/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,24 @@
#!/usr/bin/env sh
. "$(dirname "$0")/h"

echo "Running pre-push checks..." >&2

echo "Linting..." >&2

yarn run lint >&2
if [ $? -ne 0 ]; then
echo "[ACM DEV NOTE] Lint failed. Fix Linting Issues by running 'yarn run lint:fix'" >&2
echo "[ACM DEV NOTE] Push aborted!" >&2
exit 1
fi

echo "Prettier..." >&2

yarn run prettier
if [ $? -ne 0 ]; then
echo "[ACM DEV NOTE] Prettier failed. Fix Linting Issues by running 'yarn run prettier:fix'" >&2
echo "[ACM DEV NOTE] Push aborted!" >&2
exit 1
fi

echo "Pre-push checks passed. Proceeding with push." >&2
exit 0
24 changes: 0 additions & 24 deletions .husky/pre-push
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions public/data/team.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ export const OfficerTeam: TeamMember[] = [
classOf: "2027",
picture: RitamSaha.src,
},
];

export const OtherTeamMembers: TeamMember[] = [
{
name: "Aarush Narang",
position: "ACM Web Dev Website Developer",
Expand Down
5 changes: 3 additions & 2 deletions src/app/team/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import React from "react";
import Navbar from "@/components/shared/Navbar/Navbar";
import Footer from "@/components/shared/Footer/Footer";
import TeamCard from "@/components/team/Card/TeamCard";
import { Typography } from "@mui/material";
import { OfficerTeam, Professors } from "@public/data/team";
import { OfficerTeam, OtherTeamMembers, Professors } from "@public/data/team";

export default function Home() {
return (
Expand Down Expand Up @@ -36,7 +37,7 @@ export default function Home() {
Officers
</Typography>
<div className="flex flex-wrap justify-center">
{OfficerTeam.map((officer) => (
{[...OfficerTeam, ...OtherTeamMembers].map((officer) => (
<TeamCard key={officer.name} member={officer} />
))}
</div>
Expand Down