test: ensure memcache is cleared in MemcachedTest - #124
Draft
marmichalski wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@ackintosh can you run the pipeline here few times to assert it certainly solves this? 😂 I did some tests on local and it seemed fine |
marmichalski
commented
Jan 19, 2025
marmichalski
commented
Jan 19, 2025
| // Since sleeping 15 seconds as below, the `TumblingTimeWindow` contains the success count recorded above is outdated. | ||
| sleep(15); | ||
| // Since sleeping 10 seconds as below, the `TumblingTimeWindow` contains the success count recorded above is outdated. | ||
| sleep(10); |
Contributor
Author
There was a problem hiding this comment.
this is enough, so we save 5 seconds here, but add 1 above, essentially we are still faster 4 seconds 😂
marmichalski
commented
Jan 19, 2025
marmichalski
changed the title
MemcachedTestMemcachedTest
marmichalski
marked this pull request as ready for review
January 19, 2025 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.