[mri_violations] [jsx] Fix Clear filter bug for the 'Time Run' input field.#10523
Open
HachemJ wants to merge 1 commit into
Open
[mri_violations] [jsx] Fix Clear filter bug for the 'Time Run' input field.#10523HachemJ wants to merge 1 commit into
HachemJ wants to merge 1 commit into
Conversation
HachemJ
added
Module: mri_violations
MaximeBICMTL
approved these changes
Jun 8, 2026
MaximeBICMTL
left a comment
MaximeBICMTL
left a comment
Contributor
There was a problem hiding this comment.
The fix makes sense. And the before/after video is top PR description 👌
Contributor
|
Whoops, looks like I reviewed the PR at the same time it was assigned. Since I already reviewed it, unassigning Shen and assigning Dave for merge. |
kongtiaowang
added
the
Passed manual tests
Contributor
|
@driusan It is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes a bug where the 'Time Run' input field wouldn't clear after using the clear filter button on the MRI violated scans page found under Imaging --> MRI Violated Scans.
Testing instructions (if applicable)
The two videos below show the Before / After the changes with a 'valid' timestamp.
Before.Clear.Filter.bug.mov
After.Clear.Filter.bug.mov
Link(s) to related issue(s)