[DQT] Fix Default Visits Dropdown Filtering#10347
Closed
arnav-makkar wants to merge 2 commits into
Closed
Conversation
github-actions
Bot
added
the
Module: dataquery
arnav-makkar
force-pushed
the
fix/9833-visit-selection
branch
from
dd38852 to
342f791
Compare
skarya22
approved these changes
Apr 21, 2026
skarya22
left a comment
skarya22
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks Arnav - this is a great implementation.
skarya22
added
the
Passed manual tests
CamilleBeau
added
Module: dqt
Contributor
|
Rebased onto 28.0-release as a replacement PR because of permission denial on arnav-makkar's fork. #10505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes the issue where the Default Visits dropdown would display all visits regardless of the category selected.
The dropdown now correctly filters visits based on the currently displayed category (e.g., selecting AOSI shows only its valid visits).
Original: V4-V6 do not exist but still selected by default.
Final Demo Video:
9833.mov
Link(s) to related issue(s)