Skip to content

AI guidelines#176

Draft
jeppester wants to merge 7 commits into
mainfrom
ai-guidelines
Draft

AI guidelines#176
jeppester wants to merge 7 commits into
mainfrom
ai-guidelines

Conversation

@jeppester

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new section to the commit messages documentation regarding agent-generated commit messages, advising developers to write them manually or ensure they properly communicate intent. The review feedback highlights several grammatical, spelling, and formatting improvements, such as correcting 'adviced' to 'advised', hyphenating 'agent-generated', and improving sentence structure.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread technical_practices/commit_messages.md Outdated
Comment thread technical_practices/commit_messages.md Outdated
Comment thread technical_practices/commit_messages.md Outdated
Comment thread technical_practices/commit_messages.md Outdated

@hcarreras hcarreras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good start 👏

Comment thread technical_practices/agentic_programming.md Outdated
Comment thread technical_practices/agentic_programming.md Outdated
Comment thread technical_practices/agentic_programming.md Outdated
- [ ] `.agents/skills/agent-setup/SKILL.md`. Sets up MCP servers and skills for the used agent (ask agent to `invoke ".agents/skills/agent-setup/SKILL.md"`)

Some of these files will be pre-populated by our templates, make sure to adjust them for the project.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth a note that we are experimenting on how to gather the best context for the project, and currently we are experimenting with Brewale and Palette as part of the process.
The art of gathering the right context will take a big part and will keep evolving a lot during the rest of 2026.

@hcarreras hcarreras Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Gathering and sharing the right context is a big part of agentic programming, and this will keep evolving rapidly. We are experimenting with how to make useful tools, skills, and guidelines available for agents at the individual, project, and company level, while still leaving room for each project to define the business-specific context its agents need. At the time of writing, Brewale and Palette are part of that process.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really happy with the usage of the word "context" in my suggestion.
It is a complicated one because I'm mixing up two things:

  1. The context that is relevant in terms of the business
  2. "How we operate" which is closer to guidelines or commands

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this paragraph starts with "- ". It will render a bullet list with a single bullet.

I'm not sure that I think this paragraph belongs here as part of project setup. It seems more like a "where we are - where we are heading" kinda thing. Or otherwise this would have to be a lot more actionable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right. non-intentional. I was reading what was above.
Updated


Use the following checklist to set up context for your project:

- [ ] `AGENTS.md` and symlink it from `CLAUDE.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] `AGENTS.md` and symlink it from `CLAUDE.md`
- [ ] `AGENTS.md` and symlink it from `CLAUDE.md`
- [ ] `CLAUDE.md` Should operate as an index file indicating where to find information in the whole repo, including documentation, skills, or any other source of context that is external to the repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I agree on this, with this change it gets very fluffy whether or not AGENTS.md and CLAUDE.md are the same.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symlink line stays, so they are the same.

The line is addressing what Claude.md should contain. It is the single most important context file, so defining what goes there is important.

Comment thread technical_practices/agentic_programming.md

On some projects we are experimenting with autonomous agents, letting them create and submit PRs on their own.

While this might save us some time, it also introduces security / economic concerns. Agents can easily get stuck in loops, and they are vulnerable to prompt injections.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing seems opinionated.

Suggested change
While this might save us some time, it also introduces security / economic concerns. Agents can easily get stuck in loops, and they are vulnerable to prompt injections.
As we experiment with new ways of working, we have to be aware of the security and economic concerns: agents can become stuck in loops, interpret instructions too literally, and are vulnerable to prompt injection.

@jeppester jeppester Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was also not entirely happy with this sentence. The suggestion I however feel is becoming too wordy.

Could it instead be:

To avoid security and economic concerns, such as: agents getting stuck in loops, instructions interpretted too literally, and prompt injections, it is a requirement that autonomous agents:
[the list below]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Comment thread technical_practices/agentic_programming.md Outdated
jeppester and others added 5 commits July 8, 2026 14:15
Co-authored-by: Rune Philosof <57357936+runephilosof-abtion@users.noreply.github.com>
Co-authored-by: Hari Abtion <hc@abtion.com>
Co-authored-by: Hari Abtion <hc@abtion.com>
Co-authored-by: Hari Abtion <hc@abtion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants