NOISSUE - Admin UI polish — table bugs, column cleanup, and form improvements#8
Merged
Conversation
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix and UI polish update for the admin app. It resolves
several rendering bugs and improves the usability of admin tables and
create forms.
What does this do?
Bug fixes:
DataTablecaused by unstablefiltersarray reference in a
useEffectdependency — replaced with a stablestring key derived from filter keys
"actions"in TanStack Table column definitions(data column and row-actions column shared the same id) — renamed the
internal column to
_row_actionsTable cleanup:
permission blocks, actions, action applicability, and policies tables
idcolumn from roles, permission blocks, and actionstables — IDs remain accessible via the Inspect sheet
informational banners from the workspace and policies page
Edit button:
support update operations
Forms:
only inside the dropdown items, not in the selected value displayed in
the trigger
max width with text wrapping so long labels do not overflow the layout
block as its own card (with label + action badges) instead of a
comma-joined string
Docs:
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
No — these are UI-only changes (layout, rendering, component wiring).
There are no logic or data-flow changes that require new test coverage.
Did you document any new/modified features?
No new features; all changes are bug fixes or visual polish.
Notes
DataTablefix uses// eslint-disable-next-line react-hooks/exhaustive-depsto silence the linter on the intentionally-stable
filterKeysStrdependency.font-mono text-xs break-allinside a
w-40container to prevent overflow into adjacent columns.