Repository navigation
chore(contributing): refresh PR references and validation guidance - #352
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Current-head verificationReviewed head: Automatic code and security reviews both report completed at this exact head. Code findings flags are false; security finding flags are null/unavailable, so they are not represented as an affirmative false result. No review threads are posted. 12 executable fixtures and 81 documentation tests pass. The newly introduced trusted-main PR-body event workflow is not claimed as an observed production event before merge. GitHub closingIssuesReferences is empty: this PR references issue #349 without scheduling automatic issue closure. No merge, tag, publication or operational change was performed. |
Summary
Default the contributor template to non-closing references and make intentional completion a deliberate choice. Replace frozen legacy CLI/nonexistent-document checks with the current CLI, generator, existing documentation, scoped subsystem validation and explicit environment/not-run evidence.
Add a warning-only review aid for nearby negation or partial-completion wording around closing references. It reads a bounded event JSON file as data and emits fixed annotations/summary text. The main-only
pull_request_targetworkflow checks out its trustedgithub.sha, never PR head code, with read-only contents permission and no persisted checkout credentials or issue writes.Refs #349
Validation
Review and limits
Pre-PR independent review ran Claude Code 2.1.312 (requested and response-confirmed
claude-opus-5-5) and Codex CLI 0.165.0 (isolated default model; actual model ID not exposed), in parallel without tools, writes, tests or networking, on frozen input SHA-25623055c106a46819b7db872848d3c931e7d64362fad9542bc445c449ede0b0998. Codex found no mandatory code correction; Claude requested clearer limitations. The resulting template/docstring clarification and stronger permission/known-miss regressions were applied and retested afterward; the initial review is not described as a second review of identical final bytes.This heuristic cannot determine intent or reproduce GitHub's complete closing behavior. In particular, trailing qualifications, manual sidebar links and commit-message references remain manual review concerns. It warns without blocking legitimate intentional completion or changing any issue state. GitHub's documented closing-reference rules remain authoritative.
The newly introduced production event workflow will first be available after merge into main; candidate fixtures execute the actual checker now. No real-host/native-agent check is implied by this contributor change. This PR does not merge, publish or change repository protection settings.