Merge branch dev with rel-10.7 - #25995
Merged
Merged
Conversation
Copy the global feature policy to the extension property DTO
Merge branch rel-10.7 with rel-10.6
voloagent
marked this pull request as ready for review
August 17, 2026 05:19
voloagent
approved these changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Automated merge PR that resolves a bug in ABP’s ASP.NET Core MVC application configuration DTO generation for object extension policies, ensuring GlobalFeature policies are mapped correctly and covered by a regression test.
Changes:
- Fix
CachedObjectExtensionsDtoServiceto mapGlobalFeaturesfrompropertyConfig.Policy.GlobalFeatures(instead of incorrectly usingFeatures). - Add a regression unit test to ensure feature and global feature policies remain distinct.
- Update
.claude/settings.local.jsonpermissions allowlist configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService.cs | Corrects DTO mapping so GlobalFeatures uses the right policy source. |
| framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService_Tests.cs | Adds regression coverage to prevent feature/global-feature policy mixing. |
| .claude/settings.local.json | Adjusts local permissions allowlist configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+13
| public class CachedObjectExtensionsDtoService_Tests | ||
| { | ||
| private const string ModuleName = "CachedObjectExtensionsDtoServiceTestModule"; | ||
| private const string EntityName = "TestEntity"; | ||
|
|
||
| [Fact] |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #25995 +/- ##
==========================================
+ Coverage 48.79% 49.01% +0.22%
==========================================
Files 3804 3805 +1
Lines 132233 132259 +26
Branches 10027 10027
==========================================
+ Hits 64519 64825 +306
+ Misses 65788 65493 -295
- Partials 1926 1941 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.7. Please review the changed files before merging to prevent any errors that may occur.