Skip to content

Copy the global feature policy to the extension property DTO - #25993

Merged
EngincanV merged 2 commits into
rel-10.6from
maliming/object-extension-global-feature-policy
Aug 17, 2026
Merged

Copy the global feature policy to the extension property DTO#25993
EngincanV merged 2 commits into
rel-10.6from
maliming/object-extension-global-feature-policy

Conversation

@maliming

Copy link
Copy Markdown
Member

CachedObjectExtensionsDtoService filled the GlobalFeatures DTO from the feature policy, so the global feature policy never reached the clients.

Copilot AI lite review requested due to automatic review settings August 16, 2026 04:48
@maliming maliming added this to the 10.6-patch milestone Aug 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CachedObjectExtensionsDtoService so the GlobalFeatures policy is populated from the global feature policy (instead of mistakenly copying from the regular feature policy), ensuring clients receive the correct global feature policy values in extension property DTOs.

Changes:

  • Corrected mapping of ExtensionPropertyPolicyDto.GlobalFeatures to use propertyConfig.Policy.GlobalFeatures.
  • Added a focused unit test asserting Features and GlobalFeatures policies remain distinct and are serialized separately.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService.cs Fixes the DTO mapping so GlobalFeatures is sourced from Policy.GlobalFeatures rather than Policy.Features.
framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService_Tests.cs Adds regression coverage to ensure feature and global feature policies are not conflated.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.11%. Comparing base (d6d8e3b) to head (12de0fe).
⚠️ Report is 4 commits behind head on rel-10.6.

Files with missing lines Patch % Lines
...xtending/CachedObjectExtensionsDtoService_Tests.cs 0.00% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.6   #25993      +/-   ##
============================================
+ Coverage     48.91%   49.11%   +0.20%     
============================================
  Files          3759     3760       +1     
  Lines        127626   127652      +26     
  Branches       9813     9813              
============================================
+ Hits          62428    62698     +270     
+ Misses        63311    63067     -244     
  Partials       1887     1887              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming requested a review from EngincanV August 17, 2026 00:47
@EngincanV
EngincanV merged commit e7a2255 into rel-10.6 Aug 17, 2026
3 of 4 checks passed
@EngincanV
EngincanV deleted the maliming/object-extension-global-feature-policy branch August 17, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants