Copy the global feature policy to the extension property DTO - #25993
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes CachedObjectExtensionsDtoService so the GlobalFeatures policy is populated from the global feature policy (instead of mistakenly copying from the regular feature policy), ensuring clients receive the correct global feature policy values in extension property DTOs.
Changes:
- Corrected mapping of
ExtensionPropertyPolicyDto.GlobalFeaturesto usepropertyConfig.Policy.GlobalFeatures. - Added a focused unit test asserting
FeaturesandGlobalFeaturespolicies remain distinct and are serialized separately.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService.cs | Fixes the DTO mapping so GlobalFeatures is sourced from Policy.GlobalFeatures rather than Policy.Features. |
| framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/ObjectExtending/CachedObjectExtensionsDtoService_Tests.cs | Adds regression coverage to ensure feature and global feature policies are not conflated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel-10.6 #25993 +/- ##
============================================
+ Coverage 48.91% 49.11% +0.20%
============================================
Files 3759 3760 +1
Lines 127626 127652 +26
Branches 9813 9813
============================================
+ Hits 62428 62698 +270
+ Misses 63311 63067 -244
Partials 1887 1887 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CachedObjectExtensionsDtoServicefilled theGlobalFeaturesDTO from the feature policy, so the global feature policy never reached the clients.