Skip to content

Merge branch dev with rel-10.7 - #25991

Merged
voloagent merged 2 commits into
devfrom
auto-merge/rel-10-7/4772
Aug 14, 2026
Merged

Merge branch dev with rel-10.7#25991
voloagent merged 2 commits into
devfrom
auto-merge/rel-10-7/4772

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR generated automatically to merge dev with rel-10.7. Please review the changed files before merging to prevent any errors that may occur.

@voloagent
voloagent marked this pull request as ready for review August 14, 2026 13:04
Copilot AI lite review requested due to automatic review settings August 14, 2026 13:04
@voloagent
voloagent merged commit 447ac3b into dev Aug 14, 2026
2 checks passed
@voloagent
voloagent deleted the auto-merge/rel-10-7/4772 branch August 14, 2026 13:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ABP CLI’s PackageJsonFileFinder so it can recognize additional JavaScript frontend project types (Vite and Next.js) when searching for package.json files, and adds unit test coverage to validate the new detection logic.

Changes:

  • Extend project-type detection to treat vite.config.ts and next.config.ts as supported “project markers” alongside *.csproj and angular.json.
  • Add a new theory-based unit test to verify package.json discovery behavior for the supported marker files and the “no marker” case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/PackageJsonFileFinder.cs Adds Vite/Next.js marker files to the “project exists” check used to filter package.json results.
framework/test/Volo.Abp.Cli.Core.Tests/Volo/Abp/Cli/ProjectModification/PackageJsonFileFinder_Tests.cs Introduces tests covering detection for *.csproj, angular.json, vite.config.ts, next.config.ts, and the unsupported-marker scenario.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.79%. Comparing base (05a00dd) to head (14cb610).
⚠️ Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #25991      +/-   ##
==========================================
+ Coverage   48.76%   48.79%   +0.02%     
==========================================
  Files        3804     3804              
  Lines      132231   132233       +2     
  Branches    10027    10027              
==========================================
+ Hits        64486    64519      +33     
+ Misses      65820    65788      -32     
- Partials     1925     1926       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants