Skip to content

Upgrade jQuery to 4.0.0 and add jQuery Migrate - #25930

Merged
EngincanV merged 2 commits into
rel-10.7from
maliming/jquery-4
Aug 10, 2026
Merged

Upgrade jQuery to 4.0.0 and add jQuery Migrate#25930
EngincanV merged 2 commits into
rel-10.7from
maliming/jquery-4

Conversation

@maliming

@maliming maliming commented Aug 6, 2026

Copy link
Copy Markdown
Member

Resolve #25123

Upgrades @abp/jquery to jQuery 4.0.0 and adds jQuery Migrate 4.0.2 right after jQuery in the default bundle, so the plugins we ship and existing application code keep working. Removed APIs are cleaned up in our own scripts and jquery-validation moves to 1.22.1.

Migrate does not cover the behavioral changes in jQuery 4, so watch the JQMIGRATE messages in development.

Copilot AI lite review requested due to automatic review settings August 6, 2026 08:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the ABP-provided jQuery pack to jQuery 4.0.0, adds jQuery Migrate to the default MVC UI bundle to preserve compatibility, and updates/shims internal scripts/plugins to avoid removed jQuery APIs.

Changes:

  • Bump @abp/jquery to jquery ~4.0.0 and add jquery-migrate ~4.0.2.
  • Load jquery-migrate immediately after jquery in the default JQueryScriptContributor bundle.
  • Replace removed/legacy jQuery helpers ($.isFunction, $.proxy) with native equivalents in shipped scripts/plugins; update jquery-validation to ^1.22.1.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
npm/packs/jquery/src/abp.jquery.js Replaces deprecated $.isFunction usage with typeof === 'function'.
npm/packs/jquery/package.json Upgrades jQuery to 4.x and adds jquery-migrate dependency.
npm/packs/jquery/abp.resourcemapping.js Adds resource mappings for jquery-migrate dist artifacts.
npm/packs/jquery-validation/package.json Updates jquery-validation to a newer version compatible with jQuery 4.
npm/packs/bootstrap-daterangepicker/src/daterangepicker.js Replaces $.proxy usage with Function.prototype.bind for jQuery 4 compatibility.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/sweetalert2/abp-sweetalert2.js Replaces deprecated $.isFunction checks with typeof === 'function'.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/JQuery/JQueryScriptContributor.cs Adds jquery-migrate to the default jQuery bundle right after jQuery.
Suppressed comments (1)

npm/packs/bootstrap-daterangepicker/src/daterangepicker.js:1131

  • This bound handler can be simplified to a direct method bind; the current IIFE wrapper doesn’t add behavior and makes the intent harder to read.
            $(window).on('resize.daterangepicker', (function(e) { this.move(e); }).bind(this));

Comment thread npm/packs/bootstrap-daterangepicker/src/daterangepicker.js
Comment thread npm/packs/jquery/package.json
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rel-10.7@d9ae95d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../Mvc/UI/Packages/JQuery/JQueryScriptContributor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             rel-10.7   #25930   +/-   ##
===========================================
  Coverage            ?   48.59%           
===========================================
  Files               ?     3795           
  Lines               ?   131541           
  Branches            ?     9979           
===========================================
  Hits                ?    63928           
  Misses              ?    65689           
  Partials            ?     1924           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming added this to the 10.7-final milestone Aug 10, 2026
@maliming
maliming requested a review from EngincanV August 10, 2026 01:04
@EngincanV
EngincanV merged commit bafe970 into rel-10.7 Aug 10, 2026
4 checks passed
@EngincanV
EngincanV deleted the maliming/jquery-4 branch August 10, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants