Fix aria dependency error - #24694
Conversation
Changed the @angular/aria peer dependency from a version range (^21.0.0) to an exact version (21.0.0) in package.json.
Changed the @angular/aria dependency version from a range (~21.0.0) to the exact version (21.0.0) in package.json for consistency with other Angular dependencies.
There was a problem hiding this comment.
Pull request overview
This PR fixes an aria dependency error by changing the version specifier for @angular/aria from ^21.0.0 to 21.0.0 (exact version) in two package.json files.
Changes:
- Updated
@angular/ariaversion specifier innpm/ng-packs/package.jsondevDependencies - Updated
@angular/ariaversion specifier innpm/ng-packs/packages/setting-management/package.jsonpeerDependencies
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| npm/ng-packs/package.json | Changed @angular/aria from "~21.0.0" to "21.0.0" in devDependencies |
| npm/ng-packs/packages/setting-management/package.json | Changed @angular/aria from "^21.0.0" to "21.0.0" in peerDependencies |
| "@angular-eslint/template-parser": "~21.0.0", | ||
| "@angular/animations": "21.0.0", | ||
| "@angular/aria": "~21.0.0", | ||
| "@angular/aria": "21.0.0", |
There was a problem hiding this comment.
The version specifier for @angular/aria should use "~21.0.0" to be consistent with other Angular dependencies in devDependencies. Looking at lines 58, 60-72, all other @angular packages use the tilde range specifier (~21.0.0) except @angular/animations which uses an exact version. Using the tilde specifier allows patch version updates (21.0.x) which is more flexible and follows the project's convention.
| "@angular/aria": "21.0.0", | |
| "@angular/aria": "~21.0.0", |
| }, | ||
| "peerDependencies": { | ||
| "@angular/aria": "^21.0.0" | ||
| "@angular/aria": "21.0.0" |
There was a problem hiding this comment.
Using an exact version "21.0.0" in peerDependencies is too restrictive for a published library package. This means that consuming applications must have exactly version 21.0.0 installed, and won't work with patch versions like 21.0.1 or 21.0.2. For peerDependencies, a more appropriate specifier would be "^21.0.0" (allowing minor and patch updates) or ">=21.0.0" (allowing any version starting from 21.0.0), similar to how @abp/ng.components package.json uses ">=" for its peer dependencies. This provides consumers more flexibility while still ensuring compatibility.
| "@angular/aria": "21.0.0" | |
| "@angular/aria": ">=21.0.0" |
No description provided.