Repository navigation
feat: integrate guarded server-driven favorites - #40
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: RSS-QS-4-2-1
Screenshot:
Genuine local app screenshots. Isolated app-session identity used against real public API for add/remove (200/200); removed afterward. Rejection/lost-response cases are explicitly injected browser network fixtures.
Final Batch 2 deployment independently verified on 11.10.2026 at story-4 commit 0d1090c. Pages run https://github.com/abnzrdev/minigames/actions/runs/38123297013 succeeded. Served JavaScript matched that run's deployment artifact byte-for-byte. This task is included in the deployed code. Final public responsive/Guest/expiration screenshots are attached to PR #43.
Done 11.10.2026 / deadline: RS App deadline could not be independently verified.
Score: 15 / 15 (self-assessment)
Summary
Add reusable guarded POST transport with definitive/unknown outcome classification. Implement favorite control with personalized initial state, pending locks, confirmed count/state and read-only unknown recovery. Ignore stale responses after session change. Guest warning preserves the single expiration notification.
Verification
All six required commands and branch diff check passed. 12 suites / 105 tests, 39.59% statements. Real API add/remove 200/200 restored original favorite; browser pending, injected 400/network loss, read-only recovery, Guest and expired no-POST checks passed.
Commit history
3d48b88 — docs: record favorites API and recovery verification
012ca17 — fix: hide inactive favorite feedback panels
99105ae — test: verify favorite contract pending locks and ambiguous recovery
f55298b — feat: initialize personalized favorites and reconcile confirmed responses
deb4408 — feat(api): guard favorite mutations and classify ambiguous outcomes
Known issues
Four existing npm high-severity findings remain. No forced audit fix used. Deadline not independently verified. Final 80% coverage task is deferred.
Target branch
story-4