Skip to content

feat: integrate guarded server-driven favorites - #40

Merged
abnzrdev merged 5 commits into
story-4from
favorites-api
Oct 11, 2026
Merged

abnzrdev merged 5 commits into
story-4from
favorites-api

Conversation

@abnzrdev

@abnzrdev abnzrdev commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner
  1. Task: RSS-QS-4-2-1

  2. Screenshot:

favorite-pending

favorite-success

favorite-rejected

favorite-unknown

favorite-expired

Genuine local app screenshots. Isolated app-session identity used against real public API for add/remove (200/200); removed afterward. Rejection/lost-response cases are explicitly injected browser network fixtures.

  1. Deployment: https://abnzrdev.github.io/minigames/

Final Batch 2 deployment independently verified on 11.10.2026 at story-4 commit 0d1090c. Pages run https://github.com/abnzrdev/minigames/actions/runs/38123297013 succeeded. Served JavaScript matched that run's deployment artifact byte-for-byte. This task is included in the deployed code. Final public responsive/Guest/expiration screenshots are attached to PR #43.

  1. Done 11.10.2026 / deadline: RS App deadline could not be independently verified.

  2. Score: 15 / 15 (self-assessment)

  • Guest opens Auth with warning; expired action sends no mutation
  • Exact POST /api/games/{slug}/favorite body from validated session email
  • Personalized GET initializes data.isLikedByCurrentUser
  • Pending control locked with loading feedback; duplicates blocked
  • POST data.isFavorited and likesCount drive UI
  • Unknown toggle never replayed; explicit GET status reconciliation required

Summary

Add reusable guarded POST transport with definitive/unknown outcome classification. Implement favorite control with personalized initial state, pending locks, confirmed count/state and read-only unknown recovery. Ignore stale responses after session change. Guest warning preserves the single expiration notification.

Verification

All six required commands and branch diff check passed. 12 suites / 105 tests, 39.59% statements. Real API add/remove 200/200 restored original favorite; browser pending, injected 400/network loss, read-only recovery, Guest and expired no-POST checks passed.

Commit history

3d48b88 — docs: record favorites API and recovery verification
012ca17 — fix: hide inactive favorite feedback panels
99105ae — test: verify favorite contract pending locks and ambiguous recovery
f55298b — feat: initialize personalized favorites and reconcile confirmed responses
deb4408 — feat(api): guard favorite mutations and classify ambiguous outcomes

Known issues

Four existing npm high-severity findings remain. No forced audit fix used. Deadline not independently verified. Final 80% coverage task is deferred.

Target branch

story-4

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 50df7d0d-67e2-4792-82e5-7d824a8f6396

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abnzrdev
abnzrdev merged commit 846a68f into story-4 Oct 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant