Skip to content

feat(auth): guard authenticated Auth dialog entry points - #39

Merged
abnzrdev merged 3 commits into
story-4from
auth-url-guard
Oct 11, 2026
Merged

abnzrdev merged 3 commits into
story-4from
auth-url-guard

Conversation

@abnzrdev

@abnzrdev abnzrdev commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner
  1. Task: RSS-QS-4-3-4

  2. Screenshot:

auth-guard-direct

auth-guard-history

auth-guard-expired

Actual running local app with isolated valid/expired profile storage fixtures. Browser Back/Forward and URL preservation checked independently.

  1. Deployment: https://abnzrdev.github.io/minigames/

Final Batch 2 deployment independently verified on 11.10.2026 at story-4 commit 0d1090c. Pages run https://github.com/abnzrdev/minigames/actions/runs/38123297013 succeeded. Served JavaScript matched that run's deployment artifact byte-for-byte. This task is included in the deployed code. Final public responsive/Guest/expiration screenshots are attached to PR #43.

  1. Done 11.10.2026 / deadline: RS App deadline could not be independently verified.

  2. Score: 15 / 15 (self-assessment)

  • Valid session blocks UI, direct URL and history Auth entry
  • Only auth removed; path, all other query data and hash retained
  • replaceState avoids reload and extra history entry
  • One already-authenticated Snackbar per blocked entry
  • Expired/corrupt session recovery allows Guest Auth
  • Back/Forward and Game Details restoration preserved; no blocked action replay

Summary

Centralize Auth guard in native router and synchronize Auth UI against the checked session. Preserve unmanaged query/hash through regular SPA routing; guard cleanup touches only auth.

Verification

All required checks and branch diff check passed. 10 suites / 93 tests, 34.90% statements. Browser validates UI/direct/history guard, unchanged history length, expired Guest access and Details restoration with Back/Forward.

Commit history

10b9201 — docs(auth): record guard evidence and logout merge
266a808 — test(auth): verify guard recovery and URL history preservation
cd9ab97 — feat(auth): guard Auth entry points without adding history

Known issues

Four existing npm high-severity findings remain. No forced audit fix used. Deadline not independently verified. Final 80% coverage task is deferred.

Target branch

story-4

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 61a27164-5a76-46b5-9896-37b98439b230

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abnzrdev
abnzrdev merged commit af700b4 into story-4 Oct 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant