Repository navigation
feat(auth): implement logout and Guest Mode reset - #38
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: RSS-QS-4-3-3
Screenshot:
Genuine running local application with isolated profile storage fixtures. Failure scenario explicitly injects a Firebase signOut rejection at the browser module boundary; production code is unchanged.
Final Batch 2 deployment independently verified on 11.10.2026 at story-4 commit 0d1090c. Pages run https://github.com/abnzrdev/minigames/actions/runs/38123297013 succeeded. Served JavaScript matched that run's deployment artifact byte-for-byte. This task is included in the deployed code. Final public responsive/Guest/expiration screenshots are attached to PR #43.
Done 11.10.2026 / deadline: RS App deadline could not be independently verified.
Score: 15 / 15 (self-assessment)
Summary
Expose reusable session end operation and logout feedback. Add desktop/mobile controls and reset personalized game UI without closing public content. Preserve suspended Details when native close events fire. Reconcile and commit preserved Batch 1 review/tracker records with Batch 2 tracking.
Verification
All six required commands and branch diff check passed. 9 suites / 87 tests, 33.35% statements. Browser verified desktop/mobile logout, pending/error feedback, immediate Guest reset, Details retained, unrelated storage and duplicate control locking.
Commit history
0f81847 — docs: preserve Batch 1 review and track authorized Batch 2 work
6864429 — test(auth): cover logout controls immediate reset and signout errors
ca46fff — feat(auth): add header logout and reset personalized game state
7572326 — feat(auth): end app sessions and handle Firebase logout failures
Known issues
Four existing npm high-severity findings remain. No forced audit fix used. Deadline not independently verified. Final 80% coverage task is deferred.
Target branch
story-4