Skip to content

feat(auth): implement logout and Guest Mode reset - #38

Merged
abnzrdev merged 4 commits into
story-4from
logout-guest-mode
Oct 11, 2026
Merged

abnzrdev merged 4 commits into
story-4from
logout-guest-mode

Conversation

@abnzrdev

@abnzrdev abnzrdev commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner
  1. Task: RSS-QS-4-3-3

  2. Screenshot:

logout-details

logout-mobile

logout-guest

logout-pending

logout-error

Genuine running local application with isolated profile storage fixtures. Failure scenario explicitly injects a Firebase signOut rejection at the browser module boundary; production code is unchanged.

  1. Deployment: https://abnzrdev.github.io/minigames/

Final Batch 2 deployment independently verified on 11.10.2026 at story-4 commit 0d1090c. Pages run https://github.com/abnzrdev/minigames/actions/runs/38123297013 succeeded. Served JavaScript matched that run's deployment artifact byte-for-byte. This task is included in the deployed code. Final public responsive/Guest/expiration screenshots are attached to PR #43.

  1. Done 11.10.2026 / deadline: RS App deadline could not be independently verified.

  2. Score: 15 / 15 (self-assessment)

  • Working Logout control in desktop header and mobile menu
  • Only namespaced app-session key removed; Firebase signOut called
  • Guest UI restored immediately, unrelated storage retained
  • Favorite/comment-like state cleared while public Details stays open
  • Pending success/error Snackbar; signOut failure stays in Guest Mode

Summary

Expose reusable session end operation and logout feedback. Add desktop/mobile controls and reset personalized game UI without closing public content. Preserve suspended Details when native close events fire. Reconcile and commit preserved Batch 1 review/tracker records with Batch 2 tracking.

Verification

All six required commands and branch diff check passed. 9 suites / 87 tests, 33.35% statements. Browser verified desktop/mobile logout, pending/error feedback, immediate Guest reset, Details retained, unrelated storage and duplicate control locking.

Commit history

0f81847 — docs: preserve Batch 1 review and track authorized Batch 2 work
6864429 — test(auth): cover logout controls immediate reset and signout errors
ca46fff — feat(auth): add header logout and reset personalized game state
7572326 — feat(auth): end app sessions and handle Firebase logout failures

Known issues

Four existing npm high-severity findings remain. No forced audit fix used. Deadline not independently verified. Final 80% coverage task is deferred.

Target branch

story-4

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3db93949-7c6c-471f-bdd7-d881d45db045

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abnzrdev
abnzrdev merged commit 845c4ce into story-4 Oct 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant