fix(compare): numeric_eq handles BigInt/Float pairs - #20
Open
MBemera wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Adds the missing BigInt↔Float arms to
numeric_eq. Rounds bignum→f64 the same waycompare_numbersalready does, so==and=</>=agree.Three tests in
term/compare/tests.rsusing 2^70. Fail without the fix, pass with it. Gate green locally — fmt, clippy, wasm32-check, wasm-tests 80/80, workspace tests 1752/0.hope this ok. my wife sent me the in the genes podcast discussing this and thought id have a look, had a spare few hours today.
all the best -MB