chore: concept registry drift check + version bump to 0.7.1#80
chore: concept registry drift check + version bump to 0.7.1#80ablanrob wants to merge 2 commits into
Conversation
Add test/methodology/drift-check.test.ts that cross-validates concept registry entries against persona guidance prose (DM system prompt, SAP AEM plugin fragments). Uses keyword matching to catch real drift while tolerating natural wording differences between structured labels and prose. Covers Sprint 0 checklist, AEM addendum, AEM phases, document types, and persona roles (AC1.4).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughBumps CLI package version to 0.7.1 and adds a Vitest suite that verifies methodology registry concepts are covered by persona/plugin prompt fragments using keyword-extraction and overlap checks. ChangesRelease 0.7.1
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/methodology/drift-check.test.ts`:
- Around line 20-21: The tests currently use non-null assertions on
sapAemPlugin.promptFragments when assigning aemDmFragment and
aemWildcardFragment which can crash if promptFragments is undefined or keys are
missing; update the test to first assert sapAemPlugin.promptFragments exists and
that promptFragments["delivery-manager"] and promptFragments["*"] are defined
(or use optional chaining with clear fallback values) before deriving
aemDmFragment/aemWildcardFragment, or replace the direct toLowerCase calls with
guarded accesses (e.g., check promptFragments and throw a descriptive test
failure if keys are absent) to fail fast with a clear message rather than
throwing at module load time.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0061aeac-2582-40a1-a934-a92d682cfb4d
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.jsontest/methodology/drift-check.test.ts
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Summary
test/methodology/drift-check.test.ts— 43 tests that cross-validate concept registry entries against persona guidance prose (AC1.4)This completes the last open acceptance criterion from the Methodology Tools PRD.
Test plan