Skip to content

chore: concept registry drift check + version bump to 0.7.1#80

Open
ablanrob wants to merge 2 commits into
mainfrom
feat/concept-drift-check
Open

chore: concept registry drift check + version bump to 0.7.1#80
ablanrob wants to merge 2 commits into
mainfrom
feat/concept-drift-check

Conversation

@ablanrob

Copy link
Copy Markdown
Owner

Summary

  • Adds test/methodology/drift-check.test.ts — 43 tests that cross-validate concept registry entries against persona guidance prose (AC1.4)
  • Covers: Sprint 0 checklist categories/items vs DM system prompt, AEM addendum vs SAP AEM DM fragment, AEM phases vs wildcard fragment, AEM document types, persona roles
  • Uses keyword matching to catch real drift while tolerating natural differences between structured labels and prose
  • Bumps version to 0.7.1

This completes the last open acceptance criterion from the Methodology Tools PRD.

Test plan

  • 43 drift check tests passing
  • Full suite: 1010 tests passing
  • Verify drift is caught: temporarily modify a registry checklist item and confirm the test fails

Add test/methodology/drift-check.test.ts that cross-validates concept
registry entries against persona guidance prose (DM system prompt, SAP
AEM plugin fragments). Uses keyword matching to catch real drift while
tolerating natural wording differences between structured labels and
prose. Covers Sprint 0 checklist, AEM addendum, AEM phases, document
types, and persona roles (AC1.4).
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a61138e-314c-4452-a809-931eaf6930ad

📥 Commits

Reviewing files that changed from the base of the PR and between d369759 and dd3b05a.

📒 Files selected for processing (1)
  • test/methodology/drift-check.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/methodology/drift-check.test.ts

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Bumped CLI package version to 0.7.1
  • Tests

    • Added a comprehensive test suite to ensure system/persona guidance remains synchronized with methodology concepts
    • Validates coverage across guidance documentation, including SAP AEM-specific content
    • Verifies alignment between the concept registry and all persona guidance references

Walkthrough

Bumps CLI package version to 0.7.1 and adds a Vitest suite that verifies methodology registry concepts are covered by persona/plugin prompt fragments using keyword-extraction and overlap checks.

Changes

Release 0.7.1

Layer / File(s) Summary
Version bump
package.json
Package version incremented from 0.7.0 to 0.7.1.
Drift-check test suite
test/methodology/drift-check.test.ts
New Vitest tests load prompt fragments and the concept registry, extract filtered keywords, and assert coverage: Sprint 0 checklist items, AEM addendum items, AEM phase names and 3-phase description, AEM-only document types, and selected persona role methodology tags.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A tiny version hop, a careful test,

I sniff the prompts to catch what drifts from rest.
Registry and guidance, side by side they stay,
I hop through keywords to keep their truth at play.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both main changes: addition of a concept registry drift check test suite and a version bump to 0.7.1.
Description check ✅ Passed The PR description covers the summary, changes, and test plan, but does not follow the template structure with explicit Type of Change and Testing sections.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/concept-drift-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/methodology/drift-check.test.ts`:
- Around line 20-21: The tests currently use non-null assertions on
sapAemPlugin.promptFragments when assigning aemDmFragment and
aemWildcardFragment which can crash if promptFragments is undefined or keys are
missing; update the test to first assert sapAemPlugin.promptFragments exists and
that promptFragments["delivery-manager"] and promptFragments["*"] are defined
(or use optional chaining with clear fallback values) before deriving
aemDmFragment/aemWildcardFragment, or replace the direct toLowerCase calls with
guarded accesses (e.g., check promptFragments and throw a descriptive test
failure if keys are absent) to fail fast with a clear message rather than
throwing at module load time.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0061aeac-2582-40a1-a934-a92d682cfb4d

📥 Commits

Reviewing files that changed from the base of the PR and between b722ecf and d369759.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json
  • test/methodology/drift-check.test.ts

Comment thread test/methodology/drift-check.test.ts Outdated
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant