fix: suppress gosec G101 false positive on exec-credential format - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintjob onmain(golangci-lint v2.5.0) fails oninternal/config/config.gowith G101 "Potential hardcoded credentials", a false positive triggered by the wordcredentialinside the enum value"exec-credential"(the k8s ExecCredential output-format name added in #39). This adds an inline//nolint:gosecdirective, matching the convention already used twice in the same file for identical G101 false positives. Verified locally:golangci-lint run ./...reports 0 issues andgo build ./...stays green.