fix(app,server): guard stop/fail writes against a concurrent force-stop

[abhishek-verma]

Summary

Follow-up to #234 (already merged) — a final review pass on that PR now that the review session limit reset found two real gaps left over from it:

• interruptMeetingCapture was hardened against racing a concurrent stop/force-stop (UPDATE ... WHERE status NOT IN ('stopped','error')), but stopMeetingCapture and failMeetingCapture — the two functions most likely to actually race force-stop, since force-stop exists specifically to be called while one of them looks stuck — never got the same guard. A stop or fail that resolves after a concurrent force-stop already finalized the session could silently overwrite its ended_at/status. Both now use the same guarded write, skipping the SSE announce too when they lose the race.
• teardownCaptureSession's single-flight silently dropped a joining caller's flushRemainder preference in favor of whichever caller happened to start the shared task. The flag is now mutable on the shared entry, so a joiner requesting a flush can still get it as long as it arrives before that step actually runs.

Also two cleanups from the same review:

• recorder.ts's local withDeadline duplicated with-runtime-message-timeout.ts's identical helper (just a hardcoded null fallback) — consolidated into one shared withDeadline, with withRuntimeMessageTimeout as a thin specialization.
• CapturePage's Force stop button used the mutation's isPending across the whole component, so force-stopping session A also disabled the button while viewing session B; now scoped via the mutation's own variables.

Declined as accepted debt (non-blocking, cosmetic): recorder.ts still exceeds the 400-line pre-commit warning threshold (628 lines) — a candidate for splitting the start/stop race-tracking into its own module, but out of scope for this fix.

Test plan

• bun run typecheck (apps/app, apps/server) passes
• bun run lint / bun run fallow — no new warnings in changed files
• apps/server: test:capture, test:api, test:agent, trust-invariants all pass
• apps/app: full test suite passes

🤖 Generated with Claude Code

[github-actions]

❌ Tests failed — 17/2179 failed

Suite	Passed	Failed	Skipped
❌ agent	592/602	10	0
✅ build	25/25	0	0
⚠️ cli	0/0	0	0
✅ eval	91/91	0	0
✅ server-agent	492/492	0	0
✅ server-api	170/171	0	1
✅ server-browser	10/10	0	0
✅ server-capture	36/36	0	0
✅ server-integration	0/12	0	12
❌ server-lib	342/350	7	1
✅ server-memory	41/41	0	0
✅ server-root	46/50	0	4
✅ server-scheduler	27/27	0	0
✅ server-tools	272/272	0	0
⚠️ trust-invariants	0/0	0	0

Failed tests

• agent — testProvider — request body > forwards model-backed fields for non-ACP providers
• agent — testProvider — request body > forwards ACP fields when present
• agent — testProvider — request body > forwards acp-custom command for the probe spawn path
• agent — testProvider — local server unreachable > wraps a fetch failure with a clear local-server-unreachable message
• agent — agentFetch > attaches the profile header
• agent — agentFetch > does not overwrite an explicit profile header
• agent — scheduled provider resolution > falls back through the configured default when an explicit scheduled provider is local runtime only
• agent — scheduled provider resolution > falls back through the configured default when an explicit refine provider is local runtime only
• agent — fetchMcpTools > lists tools without invoking Function-based schema compilation
• agent — fetchMcpTools > follows paginated tools/list responses
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > forwards a custom baseUrl for anthropic
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > forwards a custom baseUrl for openai
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > forwards a custom baseUrl for google
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > forwards a custom baseUrl for openrouter
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > forwards baseUrl for azure and it overrides resourceName
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > azure still resolves from resourceName when baseUrl is unset
• server-lib — lib/clients/llm/provider baseUrl forwarding (test-provider / refine-prompt path) > azure throws when neither resourceName nor baseUrl is set

View workflow run