Repository navigation
chore(dependabot): audit and prune stale frontend ignore rules (#5) - #10
Merged
Merged
Conversation
Closes #5 Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Audits the temporary
npmignore clauses for/superset-frontend/in.github/dependabot.yml(issue #5) and prunes the ones whose blockers no longer hold, so Dependabot can resume proposing upgrades. Each remaining ignore now has a documented owner/exit condition.Findings per rule:
@rjsf/*(undocumented)@rjsf/*v6 declarespeerDependencies.react: ">=18"and the repo is already on the latest6.6.2, so the React-18 blocker is resolvedreact-icons(# TODO … until React >= 19)superset-frontendpackage.json, so the rule is orphaned (Dependabot only manages direct deps); latestreact-iconsalso declaresreact: "*", not>=19jest-environment-jsdom@swc/plugin-transform-importsreact-checkbox-tree(major)@babel/*(major)Net diff removes the two stale entries and adds an exit-condition note to
jest-environment-jsdom:Note: dropping
@rjsf/*andreact-iconsonly lets Dependabot propose future upgrades for maintainer review; nothing is auto-merged. If maintainers prefer to keep major@rjsfbumps gated, aversion-update:semver-majorignore can be re-added.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — config-only change.
TESTING INSTRUCTIONS
python3 -c "import yaml; yaml.safe_load(open('.github/dependabot.yml'))"parses cleanly.pre-commit run --files .github/dependabot.ymlpasses (check yamlgreen).ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/445b31ada26846c48230ff7d12009912