chore: update nx 23.1, bun 1.3.14, actions to latest, and all depende…#140
Conversation
…ncies Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
✅ Deploy Preview for adt-cli canceled.
|
📝 WalkthroughWalkthroughThe pull request upgrades CI, Docker, Bun, Node, Nx, and package tooling; updates release and TypeScript configuration; migrates Nx plugin typings; and adjusts JSON parsing and lint registry initialization. ChangesToolchain and Nx migration
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MergerNeeds Review PR exceeds the merge-gate context budget (314898 tokens); escalating to a human reviewer. Commit |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
|
PR Summary by Qodochore: upgrade Nx to 23.1 and Bun to 1.3.14; refresh CI/Docker/tooling configs
AI Description
Diagram
High-Level Assessment
Files changed (85)
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
View your CI Pipeline Execution ↗ for commit 937b50d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…erop=false Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
.github/workflows/ci.yml (1)
33-35: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse one exact Node version across workflows and images.
All four workflows now float to
lts/*, whileDockerfile,Dockerfile.adt-server, andDockerfile.mcpstill use Node 24. A future LTS change can make CI/release validate a different major than the published containers.
.github/workflows/ci.yml#L33-L35: pin the workflow Node version to the container target or update the Docker base image..github/workflows/publish-gpr.yml#L28-L31: pin the publishing Node version to the same target..github/workflows/publish.yml#L41-L45: pin the publishing Node version to the same target..github/workflows/release.yml#L68-L72: pin the release Node version to the same target.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 33 - 35, Replace the floating lts/* Node version with the container’s exact Node 24 target in the setup-node steps for .github/workflows/ci.yml:33-35, .github/workflows/publish-gpr.yml:28-31, .github/workflows/publish.yml:41-45, and .github/workflows/release.yml:68-72, keeping all workflows aligned with the Docker images.packages/adt-server-client/project.json (1)
12-15: 🩺 Stability & Availability | 🔵 TrivialKeep an explicit replacement for the disabled typecheck gate.
This command always succeeds, so Nx can report
typecheckas passed even when TypeScript is broken. Since disabling it is intentional for OOM avoidance, retain a lightweight alternative or ensure CI has another authoritative type-safety check.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/adt-server-client/project.json` around lines 12 - 15, Update the typecheck target in project.json so it remains an explicit, lightweight replacement rather than an unconditional successful echo. Preserve the OOM-avoidance intent while wiring the target to an authoritative type-safety check or meaningful validation that can fail when TypeScript is broken.packages/adt-server/project.json (1)
12-15: 🩺 Stability & Availability | 🔵 TrivialKeep an explicit replacement for the disabled typecheck gate.
The
echocommand exits successfully regardless of type errors, so this target can create a false-positivetypecheckresult. Keep a lightweight replacement check or verify that another CI target owns type safety.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/adt-server/project.json` around lines 12 - 15, Update the typecheck target in project.json so it performs a lightweight meaningful validation instead of an unconditional successful echo. Ensure the replacement preserves a nonzero result when the relevant type-safety check fails, or explicitly delegate to an existing CI target that owns this validation.tools/nx-npm-trust/src/plugin.ts (1)
126-126: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winComplete the Nx 23 runtime-export migration.
All four files update the static type but continue exporting only
createNodesV2. Export each tuple ascreateNodes, then re-exportcreateNodesV2 = createNodesonly where backward compatibility is required. Verify the correspondingindex.tsfiles expose the preferred export. Nx 23 preferscreateNodesand treatscreateNodesV2as a deprecated fallback. (nx.dev)
tools/nx-npm-trust/src/plugin.ts#L126-L126: rename the exported factory and update its index re-export.tools/nx-tsdown/src/plugin.ts#L36-L36: rename the exported factory and update its index re-export.tools/nx-typecheck/src/plugin.ts#L61-L61: rename the exported factory and update its index re-export.tools/nx-vitest/src/plugin.ts#L135-L135: rename the exported factory and update its index re-export.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/nx-npm-trust/src/plugin.ts` at line 126, Complete the Nx 23 export migration by renaming the exported factory from createNodesV2 to createNodes in tools/nx-npm-trust/src/plugin.ts#L126-L126, tools/nx-tsdown/src/plugin.ts#L36-L36, tools/nx-typecheck/src/plugin.ts#L61-L61, and tools/nx-vitest/src/plugin.ts#L135-L135, then update each corresponding index.ts to expose createNodes; add createNodesV2 as an alias only where backward compatibility is required.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 25-32: Update the actions/checkout step to set persist-credentials
to false, while preserving its existing fetch-depth and ref configuration.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 33-35: Replace the floating lts/* Node version with the
container’s exact Node 24 target in the setup-node steps for
.github/workflows/ci.yml:33-35, .github/workflows/publish-gpr.yml:28-31,
.github/workflows/publish.yml:41-45, and .github/workflows/release.yml:68-72,
keeping all workflows aligned with the Docker images.
In `@packages/adt-server-client/project.json`:
- Around line 12-15: Update the typecheck target in project.json so it remains
an explicit, lightweight replacement rather than an unconditional successful
echo. Preserve the OOM-avoidance intent while wiring the target to an
authoritative type-safety check or meaningful validation that can fail when
TypeScript is broken.
In `@packages/adt-server/project.json`:
- Around line 12-15: Update the typecheck target in project.json so it performs
a lightweight meaningful validation instead of an unconditional successful echo.
Ensure the replacement preserves a nonzero result when the relevant type-safety
check fails, or explicitly delegate to an existing CI target that owns this
validation.
In `@tools/nx-npm-trust/src/plugin.ts`:
- Line 126: Complete the Nx 23 export migration by renaming the exported factory
from createNodesV2 to createNodes in tools/nx-npm-trust/src/plugin.ts#L126-L126,
tools/nx-tsdown/src/plugin.ts#L36-L36, tools/nx-typecheck/src/plugin.ts#L61-L61,
and tools/nx-vitest/src/plugin.ts#L135-L135, then update each corresponding
index.ts to expose createNodes; add createNodesV2 as an alias only where
backward compatibility is required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 29a7dba4-cf8c-4649-90a7-13254eb0acb1
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (44)
.github/workflows/ci.yml.github/workflows/copilot-setup-steps.yml.github/workflows/docker.yml.github/workflows/publish-gpr.yml.github/workflows/publish.yml.github/workflows/release.yml.gitignoreDockerfileDockerfile.adt-serverDockerfile.mcpmigrations.jsonnx.jsonpackage.jsonpackages/adt-auth/tsconfig.jsonpackages/adt-cli/tsconfig.jsonpackages/adt-config/tsconfig.jsonpackages/adt-contracts/src/adt/runtime/schema.tspackages/adt-lint/src/lib/lint.tspackages/adt-mcp/tsconfig.jsonpackages/adt-pilot/tsconfig.jsonpackages/adt-plugin-abapgit/tsconfig.jsonpackages/adt-plugin-gcts-cli/tsconfig.jsonpackages/adt-plugin-gcts/tsconfig.jsonpackages/adt-plugin/tsconfig.jsonpackages/adt-puppeteer/tsconfig.jsonpackages/adt-rfc/tsconfig.jsonpackages/adt-server-client/project.jsonpackages/adt-server-client/tsconfig.jsonpackages/adt-server/project.jsonpackages/adt-server/tsconfig.jsonpackages/speci/vitest.config.tssamples/sample-tsdown/tsconfig.jsontools/nx-npm-trust/src/plugin.tstools/nx-npm-trust/tsconfig.jsontools/nx-sync/tsconfig.jsontools/nx-tsdown/src/plugin.tstools/nx-tsdown/tsconfig.jsontools/nx-typecheck/src/plugin.tstools/nx-typecheck/tsconfig.jsontools/nx-vitest/src/plugin.tstools/nx-vitest/tsconfig.jsontools/p2-cli/tsconfig.jsontsconfig.base.jsontsconfig.json
💤 Files with no reviewable changes (1)
- migrations.json
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
|
Code Review ✅ ApprovedUpgrades the workspace to Nx 23.1, Bun 1.3.14, and current GitHub Actions, while refactoring TypeScript configurations and plugin APIs. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
1 participant
User description
…ncies
Summary by cubic
Upgrades build tooling to
nx23.1 and Bun1.3.14, switches CI to Node LTS, refreshes dependencies, and hardens CI by disablingactions/checkoutcredential persistence. Updates Docker images and TypeScript configs to align with TypeScript 6.Dependencies
nxand all@nx/*packages to23.1.0; added@nx/vitest.1.3.14across CI and Docker; refreshedbun.lock; pinnedoven-sh/setup-bunto a SHA incopilot-setup-steps.lts/*; upgradedactions/checkout@v7,actions/setup-node@v7,nrwl/nx-set-shas@v5, and Docker actions (docker/setup-buildx-action@v4,docker/login-action@v4,docker/metadata-action@v6,docker/build-push-action@v7); disabled checkout credential persistence in CI.axios,ts-morph,vite,jest,typescript@^6,eslint,knip,verdaccio,nx-mcp).Refactors
CreateNodesV2toCreateNodes; registered@nx/vitestinnx.json.tsconfig*(dropped NX-migratedignoreDeprecationsand deprecatedesModuleInterop=false; addedtypesandnoUncheckedSideEffectImportswhere needed); minor fixes for TS 6 casts andRegistryconstructor inadt-lint.nx.json(toreleaseTag.pattern); removedmigrations.json; added.nx/migrate-runsto.gitignore.typechecktargets foradt-serverandadt-server-clientdue to OOM with MCP SDK +zod.Written for commit 99bc602. Summary will update on new commits.
Generated description
Below is a concise technical summary of the changes proposed in this PR:
graph LR subgraph "@abapify/nx-typecheck" ["@abapify/nx-typecheck"] classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px end subgraph "@abapify/nx-tsdown" ["@abapify/nx-tsdown"] createNodesV2_("createNodesV2"):::modified nx_devkit_("@nx/devkit"):::modified createNodesV2_ -- "Switches createNodesV2 typing to CreateNodes from @nx/devkit." --> nx_devkit_ classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px end subgraph "@abapify/nx-vitest" ["@abapify/nx-vitest"] classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px end subgraph "@abapify/adt-contracts" ["@abapify/adt-contracts"] classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px end subgraph "@abapify/adt-lint" ["@abapify/adt-lint"] classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px end subgraph "@abapify/nx-npm-trust" ["@abapify/nx-npm-trust"] classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13px endUpgrade the workspace to
nx23.1, Bun 1.3.14, and newer GitHub Actions/Docker tooling while refreshing core dependencies for TypeScript 6 compatibility. Align custom Nx plugins, release metadata, project configs, and affected package typechecking behavior so the monorepo keeps building and publishing cleanly after the platform upgrade.Modified files (6)
Latest Contributors(2)
nx23 and TypeScript 6 by refreshing dependencies, updating Nx plugin APIs, adjusting tsconfig defaults, and syncing release and migration metadata.Modified files (31)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)
Modified files (9)
Latest Contributors(2)