Repository navigation
Run the licensetest-tagged tests in make ci - #556
Merged
Merged
Conversation
The test-only edition override behind -tags licensetest was compiled only into the e2e image. make ci, and so the required CI job, now runs go test -race -tags licensetest on internal/app and internal/license.
check-release-consistency.sh rejects any mention of that tag in ci.yml, which builds the release-shaped image.
abahmed
force-pushed
the
ci-licensetest
branch
from
October 18, 2026 09:49
75f5884 to
ec7e622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
make test-licensetesttarget (go test -race -count=1 -tags licensetest ./internal/app/ ./internal/license/...) and makes it part ofmake ci. The required CI job (ci.yml) already runsmake ci, so it picks this up; the workflow only gets a comment update, not a duplicate step. AGENTS.md describes the change.Checks:
make test-licensetest(race), actionlint, docs-verify, line-check and diff-check passed locally. The fullmake verifycould not run locally because the disk is low. CI'smake cirun is the first full run.