ci: restore fork guard on certora workflows - #198
Open
SashaMIT wants to merge 2 commits into
Open
Conversation
The release job holds npm OIDC trusted-publishing rights (id-token: write) and contents: write, but consumes shared actions via the mutable @main branch ref. A compromised or mistakenly-pushed main on aave-dao/github-workflows would flow straight into the publish path. Pin all four aave-dao/github-workflows refs to the current main commit (c6fd9ab), tagged with a '# main' comment for readability. Made-with: Cursor
The pull_request fork guard (run certora only for same-repo PRs or pushes to the default branch) was commented out in all five certora workflows. These jobs execute repository content (make munged inside certora/) and declare id-token: write, so they should not run fork-supplied code. Uncomment the guard as originally written. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pull_requestfork guard is commented out in all five certora workflows:With the guard disabled, a fork PR triggers jobs that execute repository content (
make mungedinsidecertora/, i.e. the PR's own Makefile) while declaringid-token: writeand wiringsecrets.CERTORAKEY(empty on fork runs, but the job environment is still more privileged than fork code should meet). The guard's intent is exactly the right policy: certora runs only for same-repo PRs or pushes to the default branch.This PR uncomments the guard as originally written in all five files. Fork PRs will simply skip certora jobs (they would fail anyway without the certora key).
Test plan
Made with Cursor