ci: pin shared workflow/action refs to a commit SHA - #197
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
The release job holds npm OIDC trusted-publishing rights (id-token: write) and contents: write, but consumes shared actions via the mutable @main branch ref. A compromised or mistakenly-pushed main on aave-dao/github-workflows would flow straight into the publish path. Pin all four aave-dao/github-workflows refs to the current main commit (c6fd9ab), tagged with a '# main' comment for readability. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlgrantsid-token: write(npm OIDC trusted publishing) andcontents: write, but consumesaave-dao/github-workflows/.github/actions/setup-node@main, a mutable branch ref. If the shared repo'smainis compromised or a bad commit lands, it flows straight into the publish path that can ship npm packages under the Aave name. GitHub's security hardening guidance recommends pinning third-party (and shared-org) actions to a full-length commit SHA.Changes
Pin all four
aave-dao/github-workflowsrefs (release.yml,test.ymlx2,comment.yml) to the currentmaincommitc6fd9ab, each tagged with a# maincomment so the intended branch stays readable.Test plan
c6fd9abis the current head ofaave-dao/github-workflows@mainMade with Cursor