feat: add filtering functions to address book - #1052
Open
boredland wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Package size report 0.6%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
boredland
force-pushed
the
feat/filter-address-book
branch
2 times, most recently
from
August 27, 2025 17:39
139d855 to
af1e746
Compare
boredland
force-pushed
the
feat/filter-address-book
branch
from
August 27, 2025 17:41
af1e746 to
71fe29f
Compare
boredland
force-pushed
the
feat/filter-address-book
branch
2 times, most recently
from
August 27, 2025 20:31
af3aefa to
354afdb
Compare
so that entries can be found by properties and still be type-safe
boredland
force-pushed
the
feat/filter-address-book
branch
from
August 27, 2025 20:33
354afdb to
7d73dd0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds type-safe filtering functions to the address book, enabling developers to find entries by their properties while maintaining compile-time type safety.
- Introduces
filterAddressesfunction for finding multiple entries matching criteria - Adds
findAddressfunction for finding exactly one entry with error handling - Implements supporting type definitions for type-safe filtering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ts/utils.ts | Implements the new filtering functions with type definitions |
| tests/utils.spec.ts | Adds comprehensive tests for the new filtering functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that entries can be found by properties and still be type-safe