Skip to content

Fixes 17#206

Merged
aarond10 merged 10 commits into
aarond10:masterfrom
baranyaib90:master
Jul 19, 2026
Merged

Fixes 17#206
aarond10 merged 10 commits into
aarond10:masterfrom
baranyaib90:master

Conversation

@baranyaib90

@baranyaib90 baranyaib90 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Hi Aaron,
finally I raised the pull request:

  1. Fixes for commits merged on Feb 10, 2026.
  2. Modernization: HTTP/3 compile script update, cmake changes around warnings, using newer github actions/upload-artifact because of deprecation.
  3. Readme added how I suggest to develop the code with VS Code.
  4. Added support to set resolver IP and port. This may fix Consult the system hosts file when bootstrapping #187
  5. Truncation 2.0, because there were some issues raised like DNS package truncation caused DNS lookup fails #199, now I'm using a nuke approach to truncate instead of trying to be smart (I was not before, now I know).

Take your time.
Best regards,
Balázs

PS: these changes worked fine on my machine for a month ;)

baranyaib90 added 9 commits May 6, 2026 19:19
@baranyaib90
Revert "Prevent use-after-free in TCP client removal"
4c271ab 
This reverts commit 442815e.

There should not be any use-after-free.
@baranyaib90
Reverting code changes and minor improvements
276ae59 
- tighten TCP accept/read/send error handling and non-blocking socket setup
- improve logging for dropped TCP clients and response failures
- fix UDP bind cleanup
- correct address-list buffer bounds checks in dns_poller
- refine DNS truncation handling and related response logic
@baranyaib90
Update HTTP3 development build script
b1e5e32
@baranyaib90
Visual Studio Code development document added
c2a3d6e 
With suggestion to use clangd for IntelliSense purpose.
@baranyaib90
Uplift github actions/upload-artifact
80e756d
@baranyaib90
CMakeLists.txt: More strict compilation for security
8716c87 
Also:
- breaking long lines for readability
- set gcc/clang specific warnings
@baranyaib90
Small dns_poller optimalizations
6b4de73
@baranyaib90
Added resplver IP override and port change support
a7b4b1d 
Some polishing in doh_proxy.c
@baranyaib90
Truncation 2.0
373cab9 
Details in huge comment in code
@aarond10

aarond10 commented Jun 17, 2026 via email

Copy link
Copy Markdown
Owner

@baranyaib90

baranyaib90 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi, no hurry, get well!
It took months for me to do the changes properly, so you are in time :D

aarond10
aarond10 reviewed Jul 5, 2026
View reviewed changes
Comment thread src/dns_poller.c

// Check that we have space for at least one character plus null terminator
if (pos >= list + POLLER_ADDR_LIST_SIZE - 1) {
if ((pos - list) >= POLLER_ADDR_LIST_SIZE - 1) {

@aarond10 aarond10 Jul 5, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit -- just a comment: I don't see the risk here. pos is always greater than list so there is no risk of pos - list underflowing. Were you worried about list + POLLER_ADDR_LIST_SIZE - 1 overflowing or just preference?

@baranyaib90 baranyaib90 Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, first: thanks for approving the changes.
About this one: the base check has been added by your (most likely AI) commit 95fe77c
I did not find it wrong, so I have kept it. (Although it may be unnecessary.)
Br, Balázs

aarond10
aarond10 requested changes Jul 19, 2026
View reviewed changes

@aarond10 aarond10 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compilation changes seem to break MacOS builds. ld64 doesn't support -z. That needs to be conditional.

aarond10
aarond10 approved these changes Jul 19, 2026
View reviewed changes

@aarond10 aarond10 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the macos build issue -- easy fix.

@aarond10
aarond10 merged commit 39fbc34 into aarond10:master Jul 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarond10 aarond10 aarond10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consult the system hosts file when bootstrapping

2 participants

@baranyaib90 @aarond10