Skip to content

fix: Address audit findings — security, CI/CD, OSS readiness - #9

Merged
aadil96 merged 1 commit into
mainfrom
fix/audit-findings
May 23, 2026
Merged

fix: Address audit findings — security, CI/CD, OSS readiness#9
aadil96 merged 1 commit into
mainfrom
fix/audit-findings

Conversation

@aadil96

@aadil96 aadil96 commented May 23, 2026

Copy link
Copy Markdown
Owner

Summary

Addresses all findings from a comprehensive open-source maintainer audit.

Changes

🔴 Critical

  • API key masking: setup.sh now uses read -rs to suppress terminal echo when entering API keys
  • Lockfile: Added yarn.lock for deterministic, supply-chain-safe dependency resolution

🟠 Major

  • Coder bash scoping: Deny-list for rm -rf, sudo, git push --force, pipe-to-shell patterns
  • Profile skill dedup: Removed 5 duplicated skill dirs from profiles/ws/skills/
  • CI/CD pipeline: GitHub Actions with lint, shellcheck, frontmatter validation, sensitive data scan, README sync check
  • Secret sanitization: Redacts API keys, tokens, and credentials from debug logs and persisted delegation output

🟡 Minor

  • CODE_OF_CONDUCT.md: Contributor Covenant v2.1
  • SECURITY.md: Vulnerability reporting policy and best practices
  • Issue templates: Bug report and feature request templates
  • README sync: Skill table now matches filesystem (21 skills)
  • ShellCheck directive: Added to setup.sh

Checklist

  • No sensitive data (API keys, tokens, secrets, passwords)
  • No personal paths
  • No machine-specific config
  • Documentation updated
  • CHANGELOG.md updated

## Critical (🔴)
- Mask API key input in setup.sh (add -s flag to read calls)
- Add yarn.lock for deterministic dependency resolution

## Major (🟠)
- Restrict coder bash permissions with deny list for dangerous commands
- Remove duplicated skill files in profiles/ws/skills/
- Add GitHub Actions CI pipeline (lint, shellcheck, security scan, validation)
- Sanitize secrets from debug logs and persisted delegation output

## Minor (🟡)
- Add CODE_OF_CONDUCT.md (Contributor Covenant v2.1)
- Add SECURITY.md with vulnerability reporting policy
- Add issue templates (bug report, feature request)
- Sync README skill list with filesystem (21 skills)
- Add shellcheck directive to setup.sh
@aadil96
aadil96 merged commit e3dedc0 into main May 23, 2026
2 checks passed
@aadil96
aadil96 deleted the fix/audit-findings branch May 23, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant