Fix PowerShell window flashing during uninstall protection - #13
Open
BreakTT wants to merge 1 commit into
Open
Conversation
Launch the Windows CIM query with CREATE_NO_WINDOW so the background uninstall-protection scan does not flash a console window.
|
When will this patch be released? I tried applying it and failed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE_NO_WINDOWRoot cause
While uninstall protection is active, Focuser periodically reads the
command lines of suspected uninstall processes. On Windows this starts
PowerShell without a hidden-window creation flag, causing a console
window to briefly appear on every scan.
Testing
cargo fmt --all -- --checkcargo checkforfocuser-commonfocuser-commoncargo test -p focuser-common— 86 unit tests and 1 doc test passedFixes #12