Add CockroachDB engine support - #2
Merged
Merged
Conversation
Introduce a cockroach/ build context mirroring the postgres ETL Dockerfile. CockroachDB is PostgreSQL-compatible and the official image's entrypoint runs /docker-entrypoint-initdb.d/*.sql against COCKROACH_DATABASE under start-single-node, so the dataset pattern carries over: the builder assembles a per-dataset init script (no CREATE DATABASE header needed) and the final stage ships it on cockroachdb/cockroach, started in insecure mode for simple access. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a cockroach: context (repository aa8y/cockroach-dataset) with CockroachDB build/test/push templates and chinook/northwind/latest tags sourced from the Yugabyte PostgreSQL-dialect dumps. latest tracks chinook. Co-authored-by: Cursor <cursoragent@cursor.com>
Add test/integration/run-cockroach.sh (boots the image, waits for the init scripts to finish via the entrypoint log marker, then asserts the base-table set and per-table count(*) via `cockroach sql --insecure`), the cockroach structure-test configs, and the chinook/northwind expected-count fixtures. Co-authored-by: Cursor <cursoragent@cursor.com>
Add CockroachDB to the Databases list, a CockroachDB images section (datasets, tags, and `cockroach sql --insecure` usage), and note it under Future Work. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> ; Conflicts: ; README.md ; manifest.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cockroachengine that ships open datasets onto CockroachDB, following the existing Postgres/MySQL ETL pattern.cockroach/Dockerfile: an Alpine builder extracts/transforms/concatenates the dataset SQL into/docker-entrypoint-initdb.d/<dataset>.sql; the final image iscockroachdb/cockroachwithCOCKROACH_DATABASEset, started viastart-single-node --insecureso the init scripts auto-load.cockroachcontext inmanifest.ymlwithchinook,northwind, andlatesttags (PostgreSQL-dialect dumps from Yugabyte's sample sets).test/integration/run-cockroach.sh), structure-test configs (test/config/cockroach/), and expected row-count fixtures (test/expected/cockroach/).Test plan
dave build -c cockroachbuilds chinook/northwind/latestdave structure-test -c cockroachpassesdave test -c cockroachpasses (chinook 11 tables, northwind 14 tables)dave build && dave structure-test && dave testpasses (exit 0)Made with Cursor