Rewrite parser for openCypher 2024.3 - #4
Merged
Merged
Conversation
- Completed parser coverage: contextual keywords, CALL forms, path quantifiers/subpaths, pattern expressions, subqueries, labels, parameters, and precedence. - Added exhaustive conformance tooling: 4,882/4,882 projected TCK cases and traceability for all 377 BNF productions. - Added 235 executable witnesses and documented 20 intentional deviations; none remain open. - Tightened lexer/API behavior, including exact keyword classification, Unicode parameter names, and rejecting bare ~. - Expanded tests, property testing, five fuzz targets, TCK/scaling benchmarks, coverage enforcement, and CI. - Raised MSRV from Rust 1.86 to 1.88. - Fixed a parser hotspot, reducing the 100 KiB stress case from roughly 6–7 seconds to about 30 ms. - Updated documentation to accurately describe scope and conformance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Breaking changes
This is the planned 0.2 rewrite. It replaces the public Pest Rule and Pairs API with project-owned tokens, AST nodes, spans, and diagnostics. Migration guidance is included in docs/migration-from-0.1.md.
Known limitation
Label-heavy expression parsing still has nonlinear scaling. The benchmark suite now measures it from 4 through 64 KiB against a same-sized property-access control; this is tracked as performance debt rather than a correctness or merge blocker.