Repository navigation
fix(ci): align CI with production build target and add quality gates - #526
Merged
Merged
Conversation
- Builds with wasm32v1-none (matching build.sh and Makefile) - Adds cargo clippy with warnings denied - Adds cargo fmt --check - Uses --locked for reproducible builds - Adds WASM size check with warning threshold - Adds dependency advisory check - Adds coverage reporting with cargo-llvm-cov - Extends ABI drift check to ops tooling (invoke scripts, Makefile) - Removes committed events.json and events.txt - Adds rustfmt.toml for consistent formatting - Adds clippy.toml for lint configuration Fixes issues: - CI builds different WASM target than deployed - No lint gate (clippy, fmt) - No --locked in CI builds - make invoke-record-payment missing settlement_ref - No coverage reporting - No dependency advisory check - No WASM size check - Toolchain mismatch between CI and local - Generated events files committed to git
The clippy and rustfmt components were not installed with the toolchain. This adds them to the Install Rust step so that cargo clippy and cargo fmt work in CI.
- Removes invalid fields that were causing CI failures - Keeps only msrv field which is valid - Lint levels are controlled via -D warnings in the workflow
- Removes unstable options that require nightly channel - Uses only stable rustfmt options - Keeps consistent formatting rules
- Adds trailing commas in match arms and match blocks - Applied by running cargo fmt on the entire codebase - Fixes the fmt-check CI job
Contributor
Author
|
@Cedarich done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues:
Summary
Provide a clear summary of what this PR changes and why.
Related Issue(s)
Link any related issue(s) using
#<issue-number>.If this PR closes an issue, include
Closes #<issue-number>.Type of Change
Description
Describe the implementation details and scope of the changes.
Testing Evidence
Describe how this change was tested, including commands run or test cases executed.
Include links to test outputs, screenshots, or any relevant evidence.
Screenshots
Add screenshots, GIFs, or recordings when UI or visual behavior changed.
Checklist
closes Build the deployed WASM target in CI and add lint, coverage, and ops-tooling drift gates #510