Folia Support#324
Draft
Lorenzo0111 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds experimental Folia support using FoliaLib, replacing most Bukkit scheduler calls with FoliaLib scheduling methods.
- Updated plugin.yml to indicate Folia support
- Replaced BukkitRunnable scheduling with FoliaLib scheduler calls across multiple files
- Adjusted asynchronous and timer task scheduling methods in commands and input handler classes
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/plugin.yml | Added flag indicating Folia support |
| src/main/java/me/zombie_striker/qav/util/HeadPoseUtil.java | Replaced BukkitRunnable with FoliaLib scheduling; note potential typo in variable naming |
| src/main/java/me/zombie_striker/qav/qamini/QAMini.java | Converted scheduling calls from BukkitRunnable to FoliaLib scheduler |
| src/main/java/me/zombie_striker/qav/nms/NMSUtil.java | Updated teleport fallback to use FoliaLib scheduler |
| src/main/java/me/zombie_striker/qav/input/ModernInputListener.java | Updated task scheduling to use FoliaLib scheduler with WrappedTask |
| src/main/java/me/zombie_striker/qav/input/LegacyInputListener.java | Replaced scheduling calls for legacy input handling with FoliaLib methods |
| src/main/java/me/zombie_striker/qav/finput/inputs/* | Updated scheduling in multiple input classes to use FoliaLib scheduler methods |
| src/main/java/me/zombie_striker/qav/command/subcommands/* | Converted asynchronous command scheduling to FoliaLib scheduler |
| src/main/java/me/zombie_striker/qav/MetricsLite.java | Updated data submission scheduling to use FoliaLib scheduler |
| src/main/java/me/zombie_striker/qav/MessagesConfig.java | Replaced BukkitRunnable scheduling with FoliaLib scheduler calls |
| src/main/java/me/zombie_striker/qav/Main.java | Initialized FoliaLib and updated recurring vehicle tick scheduling |
Comments suppressed due to low confidence (1)
src/main/java/me/zombie_striker/qav/util/HeadPoseUtil.java:62
- [nitpick] The variable name 'chaningPos' appears to be a typo; consider renaming it to 'changingPos' for clarity.
updateArmorstandPart(ve, a, a.getHeadPose().getX(), ve.getAngleRotation() - chaningPos.get(ve), a.getHeadPose().getZ());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this pull request implements Folia support to the plugin using FoliaLib.
This is highly experimental and should not be used for production until merged.
Closes #300